From: Paul Mackerras <paulus@samba.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Dave Airlie <airlied@linux.ie>,
torvalds@osdl.org, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [git patch] DRM 32/64 ioctl patch..
Date: Mon, 27 Jun 2005 20:30:08 +1000 [thread overview]
Message-ID: <17087.54576.343873.481072@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <200506270811.32758.arnd@arndb.de>
Arnd Bergmann writes:
> Are you sure that comment still applies? I can't find any reference
> to set_fs in the drm code and compat_alloc_user_space() based handlers
> do not have the problem.
No, the comment is out of date; I changed the code to use
compat_alloc_user_space().
> (void __user *) arg should really be compat_ptr(arg). In theory,
> this is only necessary on s390, which does not implement drm,
> but we just do it the right way so other people don't copy
> the incorrect code.
Good point.
Paul.
prev parent reply other threads:[~2005-06-27 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-26 12:22 Dave Airlie
2005-06-26 18:39 ` Christoph Hellwig
2005-06-26 21:39 ` Dave Airlie
2005-06-27 6:11 ` Arnd Bergmann
2005-06-27 10:30 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17087.54576.343873.481072@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=airlied@linux.ie \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®