From: Lee Jones <lee@kernel.org>
To: arnd@arndb.de, lee@kernel.org, thor.thayer@linux.intel.com,
Peter Griffin <peter.griffin@linaro.org>
Cc: kernel-team@android.com, krzysztof.kozlowski@linaro.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, pankaj.dubey@samsung.com,
tudor.ambarus@linaro.org, andre.draszik@linaro.org,
saravanak@google.com, willmcvicker@google.com
Subject: Re: [PATCH 0/3] mfd syscon and altera-sysmgr cleanup
Date: Fri, 23 Feb 2024 16:02:34 +0000 [thread overview]
Message-ID: <170870415412.1726445.3923431976204064450.b4-ty@kernel.org> (raw)
In-Reply-To: <20240220115012.471689-1-peter.griffin@linaro.org>
On Tue, 20 Feb 2024 11:50:09 +0000, Peter Griffin wrote:
> Whilst implementing a driver similar to altera-sysmgr for exynos
> it was noticed during the review feedback that we should only call
> of_node_put() if the property is provided otherwise nothing has
> taken a reference on the node. Both syscon and altera-sysmgr also
> have the same issue which this series fixes.
>
> Another piece of review feedback was not to use extern keyword in
> the header file, so I also cleaned that up whilst being here.
>
> [...]
Applied, thanks!
[1/3] mfd: syscon: call of_node_put() only when of_parse_phandle() takes a ref
commit: d2b0680cf3b05490b579e71b0df6e07451977745
[2/3] mfd: syscon: remove extern from function prototypes
commit: 0db017f8edd9b9af818bc1d68ba578df1b4c4628
[3/3] mfd: altera-sysmgr: call of_node_put() only when of_parse_phandle() takes a ref
commit: e28c28a34ee9fa2ea671a20e5e7064e6220d55e7
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-02-23 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 11:50 Peter Griffin
2024-02-20 11:50 ` [PATCH 1/3] mfd: syscon: call of_node_put() only when of_parse_phandle() takes a ref Peter Griffin
2024-02-20 11:50 ` [PATCH 2/3] mfd: syscon: remove extern from function prototypes Peter Griffin
2024-02-20 11:50 ` [PATCH 3/3] mfd: altera-sysmgr: call of_node_put() only when of_parse_phandle() takes a ref Peter Griffin
2024-02-23 16:02 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170870415412.1726445.3923431976204064450.b4-ty@kernel.org \
--to=lee@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=arnd@arndb.de \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=saravanak@google.com \
--cc=thor.thayer@linux.intel.com \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®