From: Namhyung Kim <namhyung@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
linux-perf-users@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ian Rogers <irogers@google.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel@vger.kernel.org,
K Prateek Nayak <kprateek.nayak@amd.com>,
Kajol Jain <kjain@linux.ibm.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Kaige Ye <ye@kaige.org>,
Mark Rutland <mark.rutland@arm.com>,
John Garry <john.g.garry@oracle.com>,
Jiri Olsa <jolsa@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v3 1/3] perf stat: Pass fewer metric arguments
Date: Fri, 23 Feb 2024 13:14:38 -0800 [thread overview]
Message-ID: <170872283702.3880577.15255792223602721084.b4-ty@kernel.org> (raw)
In-Reply-To: <20240221070754.4163916-1-irogers@google.com>
On Tue, 20 Feb 2024 23:07:52 -0800, Ian Rogers wrote:
> Pass metric_expr and evsel rather than specific variables from the
> struct, thereby reducing the number of arguments. This will enable
> later fixes.
>
> To reduce the size of the diff, local variables are added to match the
> previous parameter names. This isn't done in the case of "name" as
> evsel->name is more intention revealing. A whitespace issue is also
> addressed.
>
> [...]
Applied to perf-tools-next, thanks!
[1/3] perf stat: Pass fewer metric arguments
commit: eee41e6b287e2adfefbe3b6fc80c66097c076f89
[2/3] perf metrics: Compute unmerged uncore metrics individually
commit: a59fb796a36bb6c2b7e6e256a9e5f9ba18109937
[3/3] perf stat: Fix metric-only aggregation index
commit: bafd4e75c1ac5a9da0aec5c7c52c7a72613a0cf3
Best regards,
--
Namhyung Kim <namhyung@kernel.org>
next prev parent reply other threads:[~2024-02-23 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 7:07 Ian Rogers
2024-02-21 7:07 ` [PATCH v3 2/3] perf metrics: Compute unmerged uncore metrics individually Ian Rogers
2024-02-21 7:07 ` [PATCH v3 3/3] perf stat: Fix metric-only aggregation index Ian Rogers
2024-02-23 21:14 ` Namhyung Kim [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-21 6:45 [PATCH v3 1/3] perf stat: Pass fewer metric arguments Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170872283702.3880577.15255792223602721084.b4-ty@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ye@kaige.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®