mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Andrew Lunn <andrew@lunn.ch>,
	 Christian Marangi <ansuelsmth@gmail.com>,
	 "David S. Miller" <davem@davemloft.net>,
	 Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	 Hans de Goede <hdegoede@redhat.com>,
	 Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
	 Heiner Kallweit <hkallweit1@gmail.com>,
	linux-leds@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: (subset) [PATCH] leds: fix ifdef check for gpio_led_register_device()
Date: Thu, 29 Feb 2024 17:43:16 +0000	[thread overview]
Message-ID: <170922859684.1626996.4061581947298770912.b4-ty@kernel.org> (raw)
In-Reply-To: <20240228093834.2230004-1-arnd@kernel.org>

On Wed, 28 Feb 2024 10:38:26 +0100, Arnd Bergmann wrote:
> gpio_led_register_device() is built whenever CONFIG_LEDS_GPIO_REGISTER is
> enabled, and this may be used even when CONFIG_NEW_LEDS is turned off.
> 
> However, the stub declaration in the header is provided for all configs
> without CONFIG_NEW_LEDS, resulting in a build failure:
> 
> drivers/leds/leds-gpio-register.c:24:1: error: redefinition of 'gpio_led_register_device'
>    24 | gpio_led_register_device(int id, const struct gpio_led_platform_data *pdata)
>       | ^
> include/linux/leds.h:646:39: note: previous definition is here
> 
> [...]

Applied, thanks!

[1/1] leds: fix ifdef check for gpio_led_register_device()
      commit: 71c65d0ff79e3b21cb3eba67d87159533daaadbc

--
Lee Jones [李琼斯]


      reply	other threads:[~2024-02-29 17:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28  9:38 Arnd Bergmann
2024-02-29 17:43 ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170922859684.1626996.4061581947298770912.b4-ty@kernel.org \
    --to=lee@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=davem@davemloft.net \
    --cc=hdegoede@redhat.com \
    --cc=hkallweit1@gmail.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=jjhiblot@traphandler.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®