From: Kalle Valo <kvalo@kernel.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org, Nishanth Menon <nm@ti.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Breno Leitao <leitao@debian.org>, Li Zetao <lizetao1@huawei.com>,
linux-wireless@vger.kernel.org
Subject: Re: [v2] wifi: wlcore: sdio: Rate limit wl12xx_sdio_raw_{read,write}() failures warns
Date: Tue, 5 Mar 2024 18:53:55 +0000 (UTC) [thread overview]
Message-ID: <170966483365.424347.18076602135809337745.kvalo@kernel.org> (raw)
In-Reply-To: <20240228101042.728881-1-javierm@redhat.com>
Javier Martinez Canillas <javierm@redhat.com> wrote:
> When these failures happen, the warning and call trace is printed which is
> excessive. Instead, just print the error but rate limited to prevent warns
> to unnecessarily pollute the kernel log buffer and make the serial console
> practically unusable.
>
> For example, on an AM625 BeaglePlay board where accessing a SDIO WiFi chip
> fails with an -110 (ETIMEDOUT) error:
>
> $ dmesg | grep "sdio write\|read failed (-110)" | wc -l
> 39
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> Reviewed-by: Breno Leitao <leitao@debian.org>
Patch applied to wireless-next.git, thanks.
f6e36d9e1c63 wifi: wlcore: sdio: Rate limit wl12xx_sdio_raw_{read,write}() failures warns
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240228101042.728881-1-javierm@redhat.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-03-05 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 10:10 [PATCH v2] " Javier Martinez Canillas
2024-03-05 18:53 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170966483365.424347.18076602135809337745.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=javierm@redhat.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®