From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Vadim Pasternak <vadimp@nvidia.com>, Daniil Dulov <d.dulov@aladdin.ru>
Cc: Mark Gross <mgross@linux.intel.com>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] platform/mellanox: mlxreg-hotplug: Remove redundant NULL-check
Date: Thu, 07 Mar 2024 12:09:44 +0200 [thread overview]
Message-ID: <170980618467.1921.15643030796886976535.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20240306153804.6509-1-d.dulov@aladdin.ru>
On Wed, 06 Mar 2024 18:38:04 +0300, Daniil Dulov wrote:
> Pointer item is checked fo NULL at mlxreg_hotplug_work_helper() and then
> it is dereferenced to produce dev_err().
> This pointer is also dereferenced before calling this function and should
> never be NULL except some piece of hardware is broken as it is said in
> the comment before the check. So, this check can be safely removed.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/mellanox: mlxreg-hotplug: Remove redundant NULL-check
commit: 576b82c3c9bf021af4984aafc105508c99660667
--
i.
prev parent reply other threads:[~2024-03-07 10:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 14:54 [PATCH] platform/mellanox: mlxreg-hotplug: Check pointer for NULL before dereferencing it Daniil Dulov
2024-02-26 15:15 ` Vadim Pasternak
2024-03-04 11:43 ` Daniil Dulov
2024-03-04 21:26 ` Vadim Pasternak
2024-03-06 15:38 ` [PATCH] platform/mellanox: mlxreg-hotplug: Remove redundant NULL-check Daniil Dulov
2024-03-06 16:01 ` Vadim Pasternak
2024-03-07 10:09 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170980618467.1921.15643030796886976535.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andy@infradead.org \
--cc=d.dulov@aladdin.ru \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®