From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9088A1E8332; Thu, 3 Sep 2026 01:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=114.242.206.163 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788397308; cv=none; b=cKBayJSvLnfCr3IHyxG0BJVcqxMC1MAiOmQsvhA3SCB2O9X35RHgVSeykzQRtkkoTVIIUGSI5bwVX70SPTVzsDqlTn9dlU31/QGcdnAJEPonhNh7nXf/MpJ6rw6uunVnQJ0iSKZlFS8KQXBYLxAvlhIijW0TG56hczL6WXq/Bo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788397308; c=relaxed/simple; bh=WwGnAA5ErGotDZh3VbAgEK5nIiocXB/JGkOeCgq4A54=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=B6orzQRYqWmqIzjqjHPe6SL4uTID+rqWHUgUYi8K2o7lxWQtaOGq8ss1vmlxD9nrT3nOx7Zc9CPQvwLIYyjNjsvhLg4vkf8g1sX7KL5Qtysk2RNmMlzGG4ax2INGLycTrZsx1JGAm7XMGpwYDRzV4HG3zGq9NkFdqKKQTBt7yH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn; spf=pass smtp.mailfrom=loongson.cn; arc=none smtp.client-ip=114.242.206.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.20.42.62]) by gateway (Coremail) with SMTP id _____8AxdvD3xphq0_8HAA--.22830S3; Thu, 03 Sep 2026 09:01:43 +0800 (CST) Received: from [10.20.42.62] (unknown [10.20.42.62]) by front1 (Coremail) with SMTP id qMiowJDxRs30xphqzu0ZAA--.42143S2; Thu, 03 Sep 2026 09:01:41 +0800 (CST) Subject: Re: [PATCH v2 02/20] KVM: selftests: Use the common minimum GPA for page tables on LoongArch To: Sean Christopherson , Marc Zyngier , Oliver Upton , Paolo Bonzini , Tianrui Zhao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Atish Patra , Alexandre Ghiti , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Itaru Kitayama , Nicholas Piggin , Ritesh Harjani References: <20260902164123.2546762-1-seanjc@google.com> <20260902164123.2546762-3-seanjc@google.com> From: Bibo Mao Message-ID: <170acb36-7542-e6f8-d834-250816ddfbfc@loongson.cn> Date: Thu, 3 Sep 2026 09:01:24 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20260902164123.2546762-3-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID:qMiowJDxRs30xphqzu0ZAA--.42143S2 X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoW7ZF43uFy8JrWDCF15CFWUJrc_yoW8CrWUpa ykAryY9r4rGr17KFZ7WwnYqFy8Wa97GFWxAr1S9ryDurnrAry2gFWxKasrXFy5Z39Yq34S v3WI93W5Za1kZwbCm3ZEXasCq-sJn29KB7ZKAUJUUUUt529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUPFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr0_Gr1UM2kKe7AKxVWUtVW8ZwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYI kI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUtVWr XwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx k0xIA0c2IEe2xFo4CEbIxvr21lc7CjxVAaw2AFwI0_GFv_Wryl42xK82IYc2Ij64vIr41l 4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1l4IxYO2xFxVAFwI0_Jw0_GFylx2IqxVAqx4xG67AKxV WUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a6rW5MIIYrxkI 7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Gr0_Xr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r 4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI 42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUShiSDUUUU On 2026/9/3 上午12:41, Sean Christopherson wrote: > Use the common minimum GPA for page tables (0x180000) on LoongArch instead > of LoongArch's custom minimum of 0x200000, so that LoongArch can use > vm_alloc_page_table() instead of open coding a rough equivalent. There are > no known reasons why LoongArch can't use a lower, less-aligned minimum. > The more-aligned value was originally selected to support huge pages for > the guest, but that only requires the address of the final allocation to be > aligned, the addresses of page table pages is irrelevant on that front. > > Signed-off-by: Sean Christopherson > --- > tools/testing/selftests/kvm/lib/loongarch/processor.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/lib/loongarch/processor.c b/tools/testing/selftests/kvm/lib/loongarch/processor.c > index 47bbde3e205a..057a77713542 100644 > --- a/tools/testing/selftests/kvm/lib/loongarch/processor.c > +++ b/tools/testing/selftests/kvm/lib/loongarch/processor.c > @@ -9,7 +9,6 @@ > #include "processor.h" > #include "ucall_common.h" > > -#define LOONGARCH_PAGE_TABLE_PHYS_MIN 0x200000 > #define LOONGARCH_GUEST_STACK_VADDR_MIN 0x200000 > > static gpa_t invalid_pgtable[4]; > @@ -57,7 +56,7 @@ void virt_arch_pgd_alloc(struct kvm_vm *vm) > child = table = 0; > for (i = 0; i < vm->mmu.pgtable_levels; i++) { > invalid_pgtable[i] = child; > - table = vm_phy_page_alloc(vm, LOONGARCH_PAGE_TABLE_PHYS_MIN, > + table = vm_phy_page_alloc(vm, KVM_GUEST_PAGE_TABLE_MIN_PADDR, > vm->memslots[MEM_REGION_PT]); > TEST_ASSERT(table, "Fail to allocate page tale at level %d\n", i); > virt_set_pgtable(vm, table, child); > Reviewed-by: Bibo Mao