mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mike Snitzer" <snitzer@gmail.com>
To: "Daniel Phillips" <phillips@phunq.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [ANNOUNCE] ddtree: A git kernel tree for storage servers
Date: Wed, 19 Mar 2008 20:54:11 -0400	[thread overview]
Message-ID: <170fa0d20803191754j2e4e5fcdg121c776d18c53dcb@mail.gmail.com> (raw)
In-Reply-To: <170fa0d20803191707y1591d389y898b34ba7b30e7be@mail.gmail.com>

On Wed, Mar 19, 2008 at 8:07 PM, Mike Snitzer <snitzer@gmail.com> wrote:

>  I typically use dm-linear devices built on MD (raid1 w/ one member
>  being remote via nbd).  The per-bdi dirty writeback accounting has
>  proven useful but I've recently hit a nasty livelock when the bdi
>  accounting for a device no longer enables writeback progress to be
>  made, e.g:
>
>  BdiWriteback:            0 kB
>  BdiReclaimable:     321408 kB
>  BdiDirtyThresh:     316364 kB
>  DirtyThresh:        381284 kB
>  BackgroundThresh:   190640 kB
>
>  With an all too familiar trace like the following:
>  ..
>   [<ffffffff8044cda6>] io_schedule_timeout+0x4b/0x79
>   [<ffffffff80271371>] congestion_wait+0x66/0x80
>   [<ffffffff802457bd>] autoremove_wake_function+0x0/0x2e
>   [<ffffffff8026c64d>] balance_dirty_pages_ratelimited_nr+0x21d/0x2b1
>   [<ffffffff80268191>] generic_file_buffered_write+0x5f3/0x711
>
>  I'm _hoping_ your simple/elegant patch can enable me to drop my 2.6.22
>  per-bdi backport and all will be right with the world.

Turns out my writeback woes were actually in... writeback ;)

I had backported Fengweng Wu's writeback work from 2.6.24 to 2.6.22
with the following commits/patches:

fix time ordering of the per superblock inode lists:
6610a0bc8dcc120daa1d93807d470d5cbf777c39
9852a0e76cd9c89e71f84e784212fdd7a97ae93a
f57b9b7b4f68e1723ca99381dc10c8bc07d6df14
c986d1e2a460cbce79d631c51519ae82c778c6c5
1b43ef91d40190b16ba10218e66d5c2c4ba11de3
c6945e77e477103057b4a639b4b01596f5257861
65cb9b47e0ea568a7a38cce7773052a6ea093629
670e4def6ef5f44315d62748134e535b479c784f
2c1365791048e8aff42138ed5f6040b3c7824a69

fix periodic superblock dirty inode flushing:
0e0f4fc22ece8e593167eccbb1a4154565c11faa

remove pages_skipped accounting in __block_write_full_page():
1f7decf6d9f06dac008b8d66935c0c3b18e564f9

speed up writeback of big dirty files:
http://lkml.org/lkml/2008/1/17/49

Given all but the last lkml.org patch reference went into 2.6.24 I'll
revisit the impact these changes have on my writeback progress when I
move to 2.6.24+.

Mike

  reply	other threads:[~2008-03-20  0:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-19  8:02 Daniel Phillips
2008-03-19 20:23 ` Mike Snitzer
2008-03-19 20:50   ` Daniel Phillips
2008-03-19 23:33   ` Daniel Phillips
2008-03-20  0:07     ` Mike Snitzer
2008-03-20  0:54       ` Mike Snitzer [this message]
2008-03-21 12:49 ` Pavel Machek
2008-03-21 18:14   ` Daniel Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170fa0d20803191754j2e4e5fcdg121c776d18c53dcb@mail.gmail.com \
    --to=snitzer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phillips@phunq.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®