mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	 Naushir Patuck <naush@raspberrypi.com>,
	 Florian Fainelli <florian.fainelli@broadcom.com>,
	 linux-media@vger.kernel.org,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>,
	 linux-rpi-kernel@lists.infradead.org,
	Conor Dooley <conor+dt@kernel.org>,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	 Kieran Bingham <kieran.bingham@ideasonboard.com>,
	 linux-arm-kernel@lists.infradead.org,
	 Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH 2/4] dt-bindings: media: Add bindings for raspberrypi,rp1-cfe
Date: Mon, 18 Mar 2024 12:33:03 -0500	[thread overview]
Message-ID: <171078318246.167654.12048961258592577365.robh@kernel.org> (raw)
In-Reply-To: <20240318-rp1-cfe-v1-2-ac6d960ff22d@ideasonboard.com>


On Mon, 18 Mar 2024 17:49:57 +0200, Tomi Valkeinen wrote:
> Add DT bindings for raspberrypi,rp1-cfe.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
>  .../bindings/media/raspberrypi,rp1-cfe.yaml        | 103 +++++++++++++++++++++
>  1 file changed, 103 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.example.dts:24:18: fatal error: dt-bindings/clock/rp1.h: No such file or directory
   24 |         #include <dt-bindings/clock/rp1.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1428: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240318-rp1-cfe-v1-2-ac6d960ff22d@ideasonboard.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-03-18 17:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 15:49 [PATCH 0/4] media: raspberrypi: Support RPi5's CFE Tomi Valkeinen
2024-03-18 15:49 ` [PATCH 1/4] media: uapi: Add meta formats for PiSP FE config and stats Tomi Valkeinen
2024-03-18 15:49 ` [PATCH 2/4] dt-bindings: media: Add bindings for raspberrypi,rp1-cfe Tomi Valkeinen
2024-03-18 17:33   ` Rob Herring [this message]
2024-03-19  6:09   ` Krzysztof Kozlowski
2024-03-19  6:46     ` Tomi Valkeinen
2024-03-19  9:31       ` Krzysztof Kozlowski
2024-03-19 13:56         ` Tomi Valkeinen
2024-03-19  6:23   ` Krzysztof Kozlowski
2024-03-19  6:48     ` Tomi Valkeinen
2024-03-19  7:00       ` Tomi Valkeinen
2024-03-19  9:32         ` Krzysztof Kozlowski
2024-03-19 12:06           ` Naushir Patuck
2024-03-19 12:21             ` Krzysztof Kozlowski
2024-03-19 12:57               ` Naushir Patuck
2024-03-19 13:02                 ` Krzysztof Kozlowski
2024-03-19 13:05                   ` Naushir Patuck
2024-03-19 14:03                     ` Tomi Valkeinen
2024-03-19 15:32                       ` Naushir Patuck
2024-03-19 17:05                         ` Tomi Valkeinen
2024-03-20  8:50                           ` Naushir Patuck
2024-03-20  9:12                             ` Krzysztof Kozlowski
2024-03-18 15:49 ` [PATCH 3/4] media: raspberrypi: Add support for RP1-CFE Tomi Valkeinen
2024-03-18 15:49 ` [PATCH 4/4] media: admin-guide: Document the Raspberry Pi CFE (rp1-cfe) Tomi Valkeinen
2024-03-19  6:05 ` [PATCH 0/4] media: raspberrypi: Support RPi5's CFE Krzysztof Kozlowski
2024-03-19  6:21   ` Tomi Valkeinen
2024-03-19  6:23     ` Krzysztof Kozlowski
2024-03-19  6:29       ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171078318246.167654.12048961258592577365.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=kernel-list@raspberrypi.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=naush@raspberrypi.com \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®