From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C258F86244; Thu, 21 Mar 2024 15:08:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711033684; cv=none; b=OBa+4S9cUKSX9c34nkitShe5T/dhLNzh0McC59lSCm2IsnGFVOo/FtlsOzpggcNhvoxh9634lkvcJ0ZySXU2os8vKcy4zWvDVZjitBxFw64EcVGdxkLiaoA6bxSWkoPKJSDHBX1E2xnMOtWS3Ica1u7f0oCY8xNj2ktEhP+ewzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711033684; c=relaxed/simple; bh=hLsN1wuBSXuii/uxujeNF1gsp0KfDr8KW6XetaBIe2U=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=sF7l2aAMTy6gbcZdYMpxgkcotViJIG3PiwrEbQo+7gQqF1K+fqtGMMRkDuGM2uThHwFkjsH5LDrqOvhgStnA8HA9b7nTidb2pH0qXLYgj6Id+6dDjluAdaoA5ovbjZdRb3oEjRW/oNs0RqYpbjwaQwIMF4g/f43NxA/q6iZ20OQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=b7lmdoFc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="b7lmdoFc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 065E3C43399; Thu, 21 Mar 2024 15:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711033684; bh=hLsN1wuBSXuii/uxujeNF1gsp0KfDr8KW6XetaBIe2U=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=b7lmdoFcrvtwHpkxNoQKmHgZvuDlkmrTHvQ4xHJkxH3U8SIsiZqpS2coFYDQ/jdSf UOMW+iJZUmsCxufcGYN2kqPHfI85m0DGI5TYoh711gGoIF/GJumwCcvPUiwq0pulr+ P+jDZcmiZu5ei12PpbSz9kVMYU98jAc4c9QSnwOUuD8aA1EQBUqzH96UGZfH+EaKeM lr7HHknPQ3z5hfdu8Z/rYvBfdtrRy8YVbXcGPODm54/YFY+t+glAHVJJ6QPwX0HGR3 C4WET+4NiM6H1bGYDDep8zp+GW9jhGAPsf3WZli0vxuYsylnhdOJoHBkVozgrcZKIE 35vB9o2t21LYg== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2 2/3] wifi: b43: Convert sprintf/snprintf to sysfs_emit From: Kalle Valo In-Reply-To: <20240315055211.1347548-2-lizhijian@fujitsu.com> References: <20240315055211.1347548-2-lizhijian@fujitsu.com> To: Li Zhijian Cc: linux-kernel@vger.kernel.org, Li Zhijian , Larry Finger , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171103368135.103792.8592804467389574911.kvalo@kernel.org> Date: Thu, 21 Mar 2024 15:08:02 +0000 (UTC) Li Zhijian wrote: > Per filesystems/sysfs.rst, show() should only use sysfs_emit() > or sysfs_emit_at() when formatting the value to be returned to user space. > > coccinelle complains that there are still a couple of functions that use > snprintf(). Convert them to sysfs_emit(). > > sprintf() will be converted as weel if they have. > > Generally, this patch is generated by > make coccicheck M= MODE=patch \ > COCCI=scripts/coccinelle/api/device_attr_show.cocci > > No functional change intended > > CC: Larry Finger > CC: Kalle Valo > CC: linux-wireless@vger.kernel.org > CC: b43-dev@lists.infradead.org > Acked-by: Larry Finger > Signed-off-by: Li Zhijian 2 patches applied to wireless-next.git, thanks. 6db5c15c8b6a wifi: b43: Convert sprintf/snprintf to sysfs_emit 48be5774b21b wifi: ti: Convert sprintf/snprintf to sysfs_emit -- https://patchwork.kernel.org/project/linux-wireless/patch/20240315055211.1347548-2-lizhijian@fujitsu.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches