From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 391C818D876; Mon, 25 Mar 2024 10:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711363800; cv=none; b=RQEBZl91nt7+4/xwh0omlYlIQk6VGeBHwllkZV7AUpboGYro+eQfC+vWuTAD5QrVnQKjL2X5mBMKqw83Yox/Dlh+bCys6phyc/t33OISws5hIMyDDZWnr74YcZd8vhg3mhbQv47SyR7sI3k52BD/7vog5J6P/scJUTcRruYJahA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711363800; c=relaxed/simple; bh=4APY93stsQD/f+BZlZm5PfAh7Rhqxtgpj8c6AP25p3k=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=WlxfEnupdP0tZHf315gLYOyBp6X8eX5j/gzheXfrUj1qHf1L8nrTA7Twyo5yuFtt7Z91YnDxwzYVFEd1D4ZEIvd6AmQnbcDUzr8zVFVb66cYUmW7L46rnGgcsFKmIlGF/ncHf6l4f2dZXtrXxp/3+cnSRs/8qdR5uMEzgfCfrZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iH0CeQlA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iH0CeQlA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E7EDC433F1; Mon, 25 Mar 2024 10:49:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711363798; bh=4APY93stsQD/f+BZlZm5PfAh7Rhqxtgpj8c6AP25p3k=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=iH0CeQlApW8aTUVFbZu1b/HMbevfcepTiv36TcCR+vHgR2RzsGJcAAXMusTOj93Sa e5tsN+k/nkCbm86QSwcKYyySqK5tbBlQi7TMejLo5C83kE3JKcaSizi8GN9341lKPH OnfZEv5C1nuKWFAt9QvTLPBlKvt6GupcrUbviHoHueVIg+DIIn+75aPn8N5WtmRgsO tnc5vln5FjMjASrvYKsaaoeJG/Z9PhuVvkP/LIROwqSd2zEFXA6z8nwhbysKad3sQ1 Nbf4H2WNL417ms1KiSSpEgBOvYdsvg6i2TxnA1B1MLtugurRK313lNurYiEj8YTqJM yOzT5kZxK/Lvw== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2 1/3] wifi: ath: Convert sprintf/snprintf to sysfs_emit From: Kalle Valo In-Reply-To: <20240315055211.1347548-1-lizhijian@fujitsu.com> References: <20240315055211.1347548-1-lizhijian@fujitsu.com> To: Li Zhijian Cc: linux-kernel@vger.kernel.org, Li Zhijian , Jeff Johnson , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, ath10k@lists.infradead.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171136379518.1022746.15442509873111996623.kvalo@kernel.org> Date: Mon, 25 Mar 2024 10:49:56 +0000 (UTC) Li Zhijian wrote: > Per filesystems/sysfs.rst, show() should only use sysfs_emit() > or sysfs_emit_at() when formatting the value to be returned to user space. > > coccinelle complains that there are still a couple of functions that use > snprintf(). Convert them to sysfs_emit(). > > sprintf() will be converted as weel if they have. > > Generally, this patch is generated by > make coccicheck M= MODE=patch \ > COCCI=scripts/coccinelle/api/device_attr_show.cocci > > No functional change intended > > CC: Kalle Valo > CC: Jeff Johnson > CC: linux-wireless@vger.kernel.org > CC: ath11k@lists.infradead.org > CC: ath10k@lists.infradead.org > Signed-off-by: Li Zhijian > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. fa1a4f15bdca wifi: ath: Convert sprintf/snprintf to sysfs_emit -- https://patchwork.kernel.org/project/linux-wireless/patch/20240315055211.1347548-1-lizhijian@fujitsu.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches