mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: INAGAKI Hiroshi <musashino.open@gmail.com>
Cc: lee@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	devicetree@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>,
	pavel@ucw.cz, conor+dt@kernel.org, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network
Date: Mon, 25 Mar 2024 08:26:15 -0500	[thread overview]
Message-ID: <171137317301.3201816.3242642839812091788.robh@kernel.org> (raw)
In-Reply-To: <20240323074326.1428-2-musashino.open@gmail.com>


On Sat, 23 Mar 2024 16:36:09 +0900, INAGAKI Hiroshi wrote:
> Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network
> connection. This is useful to distinguish those LEDs from LEDs that
> indicates status of wired "wan" connection.
> 
> example (on stock fw):
> 
> IIJ SA-W2 has "Mobile" LEDs that indicate status (no signal, too low,
> low, good) of mobile network connection via dongle connected to USB
> port.
> 
> - no signal: (none, turned off)
> -   too low: green:mobile & red:mobile (amber, blink)
> -       low: green:mobile & red:mobile (amber, turned on)
> -      good: green:mobile (turned on)
> 
> Suggested-by: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
> ---
> v1 -> v2
> 
>   - move _MOBILE before _MTD
>   - improve the commit description
> 
>  include/dt-bindings/leds/common.h | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>


  parent reply	other threads:[~2024-03-25 13:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-23  7:36 [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices INAGAKI Hiroshi
2024-03-23  7:36 ` [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi
2024-03-23 10:56   ` Krzysztof Kozlowski
2024-03-25 13:26   ` Rob Herring [this message]
2024-03-23  7:36 ` [PATCH v2 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN INAGAKI Hiroshi
2024-03-28 11:57 ` [PATCH v2 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices Lee Jones
2024-04-11 15:50 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171137317301.3201816.3242642839812091788.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hauke@hauke-m.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=musashino.open@gmail.com \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®