mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "yu-chang.lee" <yu-chang.lee@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	 MandyJH Liu <mandyjh.liu@mediatek.com>,
	xiufeng.li@mediatek.com,  linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	 linux-mediatek@lists.infradead.org,
	Ulf Hansson <ulf.hansson@linaro.org>,
	 Project_Global_Chrome_Upstream_Group@mediatek.com,
	fan.chen@mediatek.com,  linux-pm@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>,
	 linux-arm-kernel@lists.infradead.org,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: power: Add mediatek larb definition
Date: Wed, 27 Mar 2024 04:01:47 -0500	[thread overview]
Message-ID: <171153010608.1499881.4707871183250112406.robh@kernel.org> (raw)
In-Reply-To: <20240327055732.28198-3-yu-chang.lee@mediatek.com>


On Wed, 27 Mar 2024 13:57:31 +0800, yu-chang.lee wrote:
> Add Smart Multimedia Interface Local Arbiter to mediatek
> power domain.
> 
> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
> ---
>  .../devicetree/bindings/power/mediatek,power-controller.yaml  | 4 ++++
>  1 file changed, 4 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/power/mediatek,power-controller.yaml:128:6: [error] syntax error: expected <block end>, but found '<block mapping start>' (syntax)
./Documentation/devicetree/bindings/power/mediatek,power-controller.yaml:129:9: [warning] wrong indentation: expected 7 but found 8 (indentation)

dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/power/mediatek,power-controller.example.dts'
Documentation/devicetree/bindings/power/mediatek,power-controller.yaml:128:6: did not find expected key
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/power/mediatek,power-controller.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml:
while parsing a block mapping
  in "<unicode string>", line 64, column 5
did not find expected key
  in "<unicode string>", line 128, column 6
./Documentation/devicetree/bindings/power/mediatek,power-controller.yaml:128:6: did not find expected key
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240327055732.28198-3-yu-chang.lee@mediatek.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2024-03-27  9:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27  5:57 [PATCH v2 0/3] pmdomain: mediatek: solve power domain glitch issue yu-chang.lee
2024-03-27  5:57 ` [PATCH v2 1/3] pmdomain: mediatek: add smi_larb_reset function when power on yu-chang.lee
2024-03-27  5:57 ` [PATCH v2 2/3] dt-bindings: power: Add mediatek larb definition yu-chang.lee
2024-03-27  8:39   ` Krzysztof Kozlowski
2024-03-27  9:23     ` Krzysztof Kozlowski
2024-03-27  9:34       ` Yu-chang Lee (李禹璋)
2024-03-27  9:59         ` Krzysztof Kozlowski
2024-03-27 10:39           ` Yu-chang Lee (李禹璋)
2024-03-27 10:43             ` Krzysztof Kozlowski
2024-03-27 10:56               ` Yu-chang Lee (李禹璋)
2024-03-27 11:04                 ` Krzysztof Kozlowski
2024-03-27 11:55                   ` Alexandre Mergnat
2024-03-28  6:06                     ` Yu-chang Lee (李禹璋)
2024-03-28  8:44                       ` Krzysztof Kozlowski
2024-04-04 10:02                       ` Ulf Hansson
2024-03-28  7:03                   ` Yu-chang Lee (李禹璋)
2024-03-27 10:01     ` Yu-chang Lee (李禹璋)
2024-03-27 10:10       ` Krzysztof Kozlowski
2024-03-27  9:01   ` Rob Herring [this message]
2024-03-31 15:02   ` kernel test robot
2024-03-27  5:57 ` [PATCH v2 3/3] pmdomain: mediatek: support smi clamp protection yu-chang.lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171153010608.1499881.4707871183250112406.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fan.chen@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mandyjh.liu@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=xiufeng.li@mediatek.com \
    --cc=yu-chang.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®