From: Rob Herring <robh@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Eric Dumazet <edumazet@google.com>,
kernel@pengutronix.de, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Dent Project <dentproject@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-doc@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, Luis Chamberlain <mcgrof@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Russell King <linux@armlinux.org.uk>,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russ Weight <russ.weight@linux.dev>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH net-next v8 11/17] dt-bindings: net: pse-pd: Add another way of describing several PSE PIs
Date: Sun, 14 Apr 2024 11:24:20 -0500 [thread overview]
Message-ID: <171311185847.3846221.15793333674043121859.robh@kernel.org> (raw)
In-Reply-To: <20240414-feature_poe-v8-11-e4bf1e860da5@bootlin.com>
On Sun, 14 Apr 2024 16:22:00 +0200, Kory Maincent wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
>
> PSE PI setup may encompass multiple PSE controllers or auxiliary circuits
> that collectively manage power delivery to one Ethernet port.
> Such configurations might support a range of PoE standards and require
> the capability to dynamically configure power delivery based on the
> operational mode (e.g., PoE2 versus PoE4) or specific requirements of
> connected devices. In these instances, a dedicated PSE PI node becomes
> essential for accurately documenting the system architecture. This node
> would serve to detail the interactions between different PSE controllers,
> the support for various PoE modes, and any additional logic required to
> coordinate power delivery across the network infrastructure.
>
> The old usage of "#pse-cells" is unsuficient as it carries only the PSE PI
> index information.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
>
> Changes in v3:
> - New patch
>
> Changes in v4:
> - Remove $def
> - Fix pairset-names item list
> - Upgrade few properties description
> - Update the commit message
>
> Changes in v5:
> - Fix yamllint error.
> - Replace underscore by dash in properties names.
> - Add polarity-supported property.
>
> Changes in v6:
> - Reorder the pairset pinout table documentation to shrink the lines size.
> - Remove pairset and polarity as required fields.
> - Add vpwr-supply regulator supply.
>
> Changes in v7:
> - Fix weird characters issue.
> - Fix documentation nit.
> ---
> .../bindings/net/pse-pd/pse-controller.yaml | 101 ++++++++++++++++++++-
> 1 file changed, 98 insertions(+), 3 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml references a file that doesn't exist: Documentation/networking/pse-pd/pse-pi.rst
Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml: Documentation/networking/pse-pd/pse-pi.rst
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240414-feature_poe-v8-11-e4bf1e860da5@bootlin.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-04-14 16:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 14:21 [PATCH net-next v8 00/17] net: Add support for Power over Ethernet (PoE) Kory Maincent
2024-04-14 14:21 ` [PATCH net-next v8 01/17] MAINTAINERS: net: Add Oleksij to pse-pd maintainers Kory Maincent
2024-04-17 2:40 ` patchwork-bot+netdevbpf
2024-04-14 14:21 ` [PATCH net-next v8 02/17] of: property: Add fw_devlink support for pse parent Kory Maincent
2024-04-24 5:48 ` Saravana Kannan
2024-04-24 7:59 ` Kory Maincent
2024-04-14 14:21 ` [PATCH net-next v8 03/17] net: pse-pd: Rectify and adapt the naming of admin_cotrol member of struct pse_control_config Kory Maincent
2024-04-14 14:21 ` [PATCH net-next v8 04/17] ethtool: Expand Ethernet Power Equipment with c33 (PoE) alongside PoDL Kory Maincent
2024-04-17 2:20 ` Jakub Kicinski
2024-04-17 6:12 ` Kory Maincent
2024-04-14 14:21 ` [PATCH net-next v8 05/17] net: pse-pd: Introduce PSE types enumeration Kory Maincent
2024-04-14 14:21 ` [PATCH net-next v8 06/17] net: ethtool: pse-pd: Expand pse commands with the PSE PoE interface Kory Maincent
2024-04-17 2:23 ` Jakub Kicinski
2024-04-17 6:14 ` Kory Maincent
2024-04-14 14:21 ` [PATCH net-next v8 07/17] netlink: specs: Modify pse attribute prefix Kory Maincent
2024-04-14 14:21 ` [PATCH net-next v8 08/17] netlink: specs: Expand the pse netlink command with PoE interface Kory Maincent
2024-04-14 14:21 ` [PATCH net-next v8 09/17] MAINTAINERS: Add myself to pse networking maintainer Kory Maincent
2024-04-14 14:21 ` [PATCH net-next v8 10/17] net: pse-pd: Add support for PSE PIs Kory Maincent
2024-04-17 2:15 ` Jakub Kicinski
2024-04-17 2:28 ` Jakub Kicinski
2024-04-14 14:22 ` [PATCH net-next v8 11/17] dt-bindings: net: pse-pd: Add another way of describing several " Kory Maincent
2024-04-14 16:24 ` Rob Herring [this message]
2024-04-14 14:22 ` [PATCH net-next v8 12/17] net: pse-pd: Add support for setup_pi_matrix callback Kory Maincent
2024-04-14 14:22 ` [PATCH net-next v8 13/17] net: pse-pd: Use regulator framework within PSE framework Kory Maincent
2024-04-14 14:22 ` [PATCH net-next v8 14/17] dt-bindings: net: pse-pd: Add bindings for PD692x0 PSE controller Kory Maincent
2024-04-14 14:22 ` [PATCH net-next v8 15/17] net: pse-pd: Add PD692x0 PSE controller driver Kory Maincent
2024-04-14 14:22 ` [PATCH net-next v8 16/17] dt-bindings: net: pse-pd: Add bindings for TPS23881 PSE controller Kory Maincent
2024-04-14 14:22 ` [PATCH net-next v8 17/17] net: pse-pd: Add TI TPS23881 PSE controller driver Kory Maincent
2024-04-16 21:56 ` [PATCH net-next v8 00/17] net: Add support for Power over Ethernet (PoE) Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171311185847.3846221.15793333674043121859.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dentproject@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=russ.weight@linux.dev \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®