From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F72B156977; Mon, 15 Apr 2024 23:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713222334; cv=none; b=VrT5N84XiJtBY9BnuGtb48cQ2KnJkEceWeUQh9M4QYSdGncoM9OdomXt/dlpIz1dOkUrYYEUtLmsx60B+eas/0N2doTgHXMrN9j1DcfSeEIbYdMol3bmw4FqFr7Yf9hp00fgoDjOa8SrvmwLVmspDrVTeNlRlgbg61UVxyhEI3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713222334; c=relaxed/simple; bh=ujka/03jMUb0XAncsAq1DSp6vUMODs+NmGkGQhLYg68=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=APnU3uLh8EBtDFJLXntWat0Rma+Jiqn3jhrTnFZx+dVEGXObSgiNQIlknZeKjg4h4Hwjazs/28YOPw1o/RH38CRAAldTdff9W3MccXF1LtWtFXHshicZ7L0Djr1lk+zWbP+3tuaH2ZV/9sudiTRsxuPGAYqUTdOMBDFp8iMUDVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Gx6d951X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gx6d951X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39EA4C113CC; Mon, 15 Apr 2024 23:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713222333; bh=ujka/03jMUb0XAncsAq1DSp6vUMODs+NmGkGQhLYg68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gx6d951XUcnisiPltyGh2R86ooQuEYTrxs3fuuz33iLrsJZKIr4Yh7kIEhpgZYT0u +cscArqD1yK5tD3G0VQc+Ap7mBDtsJdrKBNrU1S3p32nkeZGHxgvSM3TImP1L3AnT+ F1Nn6ThGM/Nxfr+vuJQoaLTePGQ8EfFhYr8JHlpahucJC6/h2JaGVs/KfAy6oNyMOG N+dAJk9Pas+V8JpKU1LFAZJsJJQ8Z4hWi+pQzAMfGyvrh+MkM1rVX2dbNMvB1H0UsB 9dOhkk3jUFJLdhWOMw6dCldHzd9gEp8IhUOIXELJODAGnL83vI0TUDlFCajFJHVR0y /+aHDeMK9aFHg== Date: Mon, 15 Apr 2024 18:05:30 -0500 From: Rob Herring To: Chen-Yu Tsai Cc: Matthias Brugger , Krzysztof Kozlowski , devicetree@vger.kernel.org, AngeloGioacchino Del Regno , linux-bluetooth@vger.kernel.org, Rob Herring , netdev@vger.kernel.org, Marcel Holtmann , linux-arm-kernel@lists.infradead.org, Luiz Augusto von Dentz , Sean Wang , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Conor Dooley Subject: Re: [PATCH v3 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth Message-ID: <171322232789.252337.16326980700188367647.robh@kernel.org> References: <20240412073046.1192744-1-wenst@chromium.org> <20240412073046.1192744-2-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240412073046.1192744-2-wenst@chromium.org> On Fri, 12 Apr 2024 15:30:42 +0800, Chen-Yu Tsai wrote: > The MediaTek MT7921S is a WiFi/Bluetooth combo chip that works over > SDIO. WiFi and Bluetooth are separate SDIO functions within the chip. > While the Bluetooth SDIO function is fully discoverable, the chip has > a pin that can reset just the Bluetooth core, as opposed to the full > chip. This should be described in the device tree. > > Add a device tree binding for the Bluetooth SDIO function of the MT7921S > specifically to document the reset line. This binding is based on the MMC > controller binding, which specifies one device node per SDIO function. > > Cc: Sean Wang > Signed-off-by: Chen-Yu Tsai > --- > Changes since v2: > - Expand description and commit message to clearly state that WiFi and > Bluetooth are separate SDIO functions, and that each function should > be a separate device node, as specified by the MMC binding. > - Change 'additionalProperties' to 'unevaluatedProperties' > - Add missing separating new line > - s/ot/to/ > > Angelo's reviewed-by was not picked up due to the above changes. > > Changes since v1: > - Reworded descriptions > - Moved binding maintainer section before description > - Added missing reference to bluetooth-controller.yaml > - Added missing GPIO header to example > --- > .../bluetooth/mediatek,mt7921s-bluetooth.yaml | 55 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml > Reviewed-by: Rob Herring