mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
	 Dent Project <dentproject@linuxfoundation.org>,
	 linux-kernel@vger.kernel.org,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	 kernel@pengutronix.de, "Rafael J. Wysocki" <rafael@kernel.org>,
	 linux-doc@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Russell King <linux@armlinux.org.uk>,
	Russ Weight <russ.weight@linux.dev>,
	 Jakub Kicinski <kuba@kernel.org>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	 Andrew Lunn <andrew@lunn.ch>, Mark Brown <broonie@kernel.org>,
	 Eric Dumazet <edumazet@google.com>,
	 Oleksij Rempel <o.rempel@pengutronix.de>,
	 Frank Rowand <frowand.list@gmail.com>,
	Paolo Abeni <pabeni@redhat.com>,
	 "David S. Miller" <davem@davemloft.net>,
	 Maxime Chevallier <maxime.chevallier@bootlin.com>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 Jonathan Corbet <corbet@lwn.net>,
	netdev@vger.kernel.org,  Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH net-next v9 08/14] dt-bindings: net: pse-pd: Add another way of describing several PSE PIs
Date: Wed, 17 Apr 2024 10:34:26 -0500	[thread overview]
Message-ID: <171336806575.2618779.157615998420721814.robh@kernel.org> (raw)
In-Reply-To: <20240417-feature_poe-v9-8-242293fd1900@bootlin.com>


On Wed, 17 Apr 2024 16:39:56 +0200, Kory Maincent wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> 
> PSE PI setup may encompass multiple PSE controllers or auxiliary circuits
> that collectively manage power delivery to one Ethernet port.
> Such configurations might support a range of PoE standards and require
> the capability to dynamically configure power delivery based on the
> operational mode (e.g., PoE2 versus PoE4) or specific requirements of
> connected devices. In these instances, a dedicated PSE PI node becomes
> essential for accurately documenting the system architecture. This node
> would serve to detail the interactions between different PSE controllers,
> the support for various PoE modes, and any additional logic required to
> coordinate power delivery across the network infrastructure.
> 
> The old usage of "#pse-cells" is unsuficient as it carries only the PSE PI
> index information.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Changes in v3:
> - New patch
> 
> Changes in v4:
> - Remove $def
> - Fix pairset-names item list
> - Upgrade few properties description
> - Update the commit message
> 
> Changes in v5:
> - Fix yamllint error.
> - Replace underscore by dash in properties names.
> - Add polarity-supported property.
> 
> Changes in v6:
> - Reorder the pairset pinout table documentation to shrink the lines size.
> - Remove pairset and polarity as required fields.
> - Add vpwr-supply regulator supply.
> 
> Changes in v7:
> - Fix weird characters issue.
> - Fix documentation nit.
> ---
>  .../bindings/net/pse-pd/pse-controller.yaml        | 101 ++++++++++++++++++++-
>  1 file changed, 98 insertions(+), 3 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml references a file that doesn't exist: Documentation/networking/pse-pd/pse-pi.rst
Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml: Documentation/networking/pse-pd/pse-pi.rst

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240417-feature_poe-v9-8-242293fd1900@bootlin.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-04-17 15:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17 14:39 [PATCH net-next v9 00/14] net: Add support for Power over Ethernet (PoE) Kory Maincent
2024-04-17 14:39 ` [PATCH net-next v9 01/14] ethtool: Expand Ethernet Power Equipment with c33 (PoE) alongside PoDL Kory Maincent
2024-04-19  1:50   ` patchwork-bot+netdevbpf
2024-04-17 14:39 ` [PATCH net-next v9 02/14] net: pse-pd: Introduce PSE types enumeration Kory Maincent
2024-04-17 14:39 ` [PATCH net-next v9 03/14] net: ethtool: pse-pd: Expand pse commands with the PSE PoE interface Kory Maincent
2024-04-17 14:39 ` [PATCH net-next v9 04/14] netlink: specs: Modify pse attribute prefix Kory Maincent
2024-04-17 14:39 ` [PATCH net-next v9 05/14] netlink: specs: Expand the pse netlink command with PoE interface Kory Maincent
2024-04-17 14:39 ` [PATCH net-next v9 06/14] MAINTAINERS: Add myself to pse networking maintainer Kory Maincent
2024-04-17 14:39 ` [PATCH net-next v9 07/14] net: pse-pd: Add support for PSE PIs Kory Maincent
2024-04-17 14:39 ` [PATCH net-next v9 08/14] dt-bindings: net: pse-pd: Add another way of describing several " Kory Maincent
2024-04-17 15:34   ` Rob Herring [this message]
2024-04-18 10:07     ` Oleksij Rempel
2024-04-18 14:57       ` Kory Maincent
2024-04-17 14:39 ` [PATCH net-next v9 09/14] net: pse-pd: Add support for setup_pi_matrix callback Kory Maincent
2024-04-17 14:39 ` [PATCH net-next v9 10/14] net: pse-pd: Use regulator framework within PSE framework Kory Maincent
2024-04-17 14:39 ` [PATCH net-next v9 11/14] dt-bindings: net: pse-pd: Add bindings for PD692x0 PSE controller Kory Maincent
2024-04-17 14:40 ` [PATCH net-next v9 12/14] net: pse-pd: Add PD692x0 PSE controller driver Kory Maincent
2024-04-17 14:40 ` [PATCH net-next v9 13/14] dt-bindings: net: pse-pd: Add bindings for TPS23881 PSE controller Kory Maincent
2024-04-17 14:40 ` [PATCH net-next v9 14/14] net: pse-pd: Add TI TPS23881 PSE controller driver Kory Maincent
2024-04-17 20:57 ` [PATCH net-next v9 00/14] net: Add support for Power over Ethernet (PoE) Kyle Swenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171336806575.2618779.157615998420721814.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dentproject@linuxfoundation.org \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hkallweit1@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kory.maincent@bootlin.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mcgrof@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=russ.weight@linux.dev \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®