mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: torvalds@osdl.org, akpm@osdl.org
Cc: anton@samba.org, hbabu@us.ibm.com, linux-kernel@vger.kernel.org
Subject: [PATCH] Xmon bug fix for soft-reset
Date: Wed, 3 Aug 2005 15:08:18 +1000	[thread overview]
Message-ID: <17136.20802.654471.934480@cargo.ozlabs.ibm.com> (raw)

From: Haren Myneni <haren@us.ibm.com>

For soft reset during system hang, got an error "CPU did not take 
control" for some CPUs even though they responded to soft-reset (called 
SystemReset, die and called debugger - xmon).   First these CPUs entered 
into xmon by IPI callback and then got a soft-reset exception and 
re-entered into xmon again. The first CPU which re-entered into xmon got 
the output lock and made into xmon successfully without unlocking. 
Hence, the next CPU(s) which re-entered into xmon try to acquire a lock  
(get_output_lock). Therefore, we can not view state of those CPU(s).

[This is a simple, very low risk, obvious fix for an obvious bug, and
should go into 2.6.13.  -- paulus]

Signed-off-by: Haren Myneni <hbabu@us.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
---
--- linux-2.6.13-rc4-git4/arch/ppc64/xmon/xmon.c.orig	2005-08-01 22:31:09.000000000 -0700
+++ linux-2.6.13-rc4-git4/arch/ppc64/xmon/xmon.c	2005-08-01 22:33:16.000000000 -0700
@@ -329,13 +329,16 @@ int xmon_core(struct pt_regs *regs, int 
 		printf("cpu 0x%x: Exception %lx %s in xmon, "
 		       "returning to main loop\n",
 		       cpu, regs->trap, getvecname(TRAP(regs)));
+		release_output_lock();
 		longjmp(xmon_fault_jmp[cpu], 1);
 	}
 
 	if (setjmp(recurse_jmp) != 0) {
 		if (!in_xmon || !xmon_gate) {
+			get_output_lock();
 			printf("xmon: WARNING: bad recursive fault "
 			       "on cpu 0x%x\n", cpu);
+			release_output_lock();
 			goto waiting;
 		}
 		secondary = !(xmon_taken && cpu == xmon_owner);

                 reply	other threads:[~2005-08-03  5:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17136.20802.654471.934480@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=akpm@osdl.org \
    --cc=anton@samba.org \
    --cc=hbabu@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®