From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753674AbcHZLO2 (ORCPT ); Fri, 26 Aug 2016 07:14:28 -0400 Received: from gloria.sntech.de ([95.129.55.99]:54557 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753015AbcHZLO0 (ORCPT ); Fri, 26 Aug 2016 07:14:26 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Xing Zheng Cc: linux-rockchip@lists.infradead.org, dianders@chromium.org, jay.xu@rock-chips.com, huangtao@rock-chips.com, Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Caesar Wang , Brian Norris , Elaine Zhang , David Wu , Masahiro Yamada , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: rockchip: fix the address map for WDT0 and WDT1 Date: Fri, 26 Aug 2016 13:14:01 +0200 Message-ID: <17136512.4k6A6uo3GV@diego> User-Agent: KMail/4.14.10 (Linux/4.6.0-1-amd64; KDE/4.14.22; x86_64; ; ) In-Reply-To: <1472208482-30862-1-git-send-email-zhengxing@rock-chips.com> References: <1472208482-30862-1-git-send-email-zhengxing@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 26. August 2016, 18:48:01 schrieb Xing Zheng: > To rename "watchdog" to "watchdog0" explicitly for looking up. > Dues to incorrect description in the TRM, the WDTs base address > should be fixed and swap them like this: > WDT0 - 0xff848000 > WDT1 - 0xff840000 > > And, it is right that only WDT0 can generate global software reset. > We will update the TRM to fix it. > > Signed-off-by: Xing Zheng I had applied v1 already, so I have now just amended it with the watchdog0 change [0]. In any case the fix is in my dts64 branch for 4.9 now. Heiko [0] https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=8859d81a562e484f06712fadb8886d78ed0be851