From: "tip-bot2 for Vincent Guittot" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Ingo Molnar <mingo@kernel.org>, Lukasz Luba <lukasz.luba@arm.com>,
Dhruva Gole <d-gole@ti.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] thermal/cpufreq: Remove arch_update_thermal_pressure()
Date: Wed, 24 Apr 2024 10:22:15 -0000 [thread overview]
Message-ID: <171395413551.10875.5850326292682493077.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20240326091616.3696851-4-vincent.guittot@linaro.org>
The following commit has been merged into the sched/core branch of tip:
Commit-ID: c281afe24fc51691e65f59ea66eefa14cbdfa0e7
Gitweb: https://git.kernel.org/tip/c281afe24fc51691e65f59ea66eefa14cbdfa0e7
Author: Vincent Guittot <vincent.guittot@linaro.org>
AuthorDate: Tue, 26 Mar 2024 10:16:14 +01:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Wed, 24 Apr 2024 12:08:00 +02:00
thermal/cpufreq: Remove arch_update_thermal_pressure()
arch_update_thermal_pressure() aims to update fast changing signal which
should be averaged using PELT filtering before being provided to the
scheduler which can't make smart use of fast changing signal.
cpufreq now provides the maximum freq_qos pressure on the capacity to the
scheduler, which includes cpufreq cooling device. Remove the call to
arch_update_thermal_pressure() in cpufreq cooling device as this is
handled by cpufreq_get_pressure().
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Lukasz Luba <lukasz.luba@arm.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/r/20240326091616.3696851-4-vincent.guittot@linaro.org
---
drivers/thermal/cpufreq_cooling.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c
index 9d1b145..280071b 100644
--- a/drivers/thermal/cpufreq_cooling.c
+++ b/drivers/thermal/cpufreq_cooling.c
@@ -477,7 +477,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev,
unsigned long state)
{
struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata;
- struct cpumask *cpus;
unsigned int frequency;
int ret;
@@ -494,8 +493,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev,
ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency);
if (ret >= 0) {
cpufreq_cdev->cpufreq_state = state;
- cpus = cpufreq_cdev->policy->related_cpus;
- arch_update_thermal_pressure(cpus, frequency);
ret = 0;
}
next prev parent reply other threads:[~2024-04-24 10:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 9:16 [PATCH v6 0/5] Rework system pressure interface to the scheduler Vincent Guittot
2024-03-26 9:16 ` [PATCH v6 1/5] cpufreq: Add a cpufreq pressure feedback for " Vincent Guittot
2024-03-26 11:44 ` Dhruva Gole
2024-04-24 10:22 ` [tip: sched/core] " tip-bot2 for Vincent Guittot
2024-03-26 9:16 ` [PATCH v6 2/5] sched: Take cpufreq feedback into account Vincent Guittot
2024-04-24 10:22 ` [tip: sched/core] sched/cpufreq: " tip-bot2 for Vincent Guittot
2024-03-26 9:16 ` [PATCH v6 3/5] thermal/cpufreq: Remove arch_update_thermal_pressure() Vincent Guittot
2024-03-26 11:46 ` Dhruva Gole
2024-04-24 10:22 ` tip-bot2 for Vincent Guittot [this message]
2024-03-26 9:16 ` [PATCH v6 4/5] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure Vincent Guittot
2024-04-24 10:22 ` [tip: sched/core] sched/cpufreq: Rename arch_update_thermal_pressure() => arch_update_hw_pressure() tip-bot2 for Vincent Guittot
2024-04-30 11:23 ` [PATCH v6 4/5] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure Konrad Dybcio
2024-04-30 12:00 ` Vincent Guittot
2024-04-30 12:15 ` Konrad Dybcio
2024-03-26 9:16 ` [PATCH v6 5/5] sched/pelt: Remove shift of thermal clock Vincent Guittot
2024-04-24 10:22 ` [tip: sched/core] " tip-bot2 for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171395413551.10875.5850326292682493077.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=d-gole@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mingo@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®