From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta-64-225.siemens.flowmailer.net (mta-64-225.siemens.flowmailer.net [185.136.64.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C460763E4 for ; Mon, 3 Jun 2024 10:05:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.136.64.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717409116; cv=none; b=M3laZ43e2EdEQsnfn2QgappF9ADN6ydAz6F6iL8nU4tHGoXemcmm4bqdNSj/aiKa5SbE5eKdcEEali0RblI1afxyPAaWAo6cIdCFdJ1XuT9VUaavs1RkCCxC6ITBACq+ZpCZzu6ASfJwcy/CJ2lgvrDzBo4D8Wf094xMPAxG0tM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717409116; c=relaxed/simple; bh=ZlM9K7YbhnssYFwPW3MJ4UGZUwh5ufAgHkPPcrG0P7g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FTZ98s/i5NsYEX+rKhiXViANJShIg+ZffJZCDFC4tghe3Grh46ZFsqHy7Gc7Iq82K8TmCwItzbh5zF+H1+xIoU3sIs6TqoGtEGGCGj+mjS/o4+rNuPBAqIEZ0qmQSta/yR0O/7us3rfalatfPqAnHBi08ECA5rPgwU9KmAgnSI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=siemens.com; spf=pass smtp.mailfrom=rts-flowmailer.siemens.com; dkim=pass (1024-bit key) header.d=siemens.com header.i=diogo.ivo@siemens.com header.b=NGwz4KAY; arc=none smtp.client-ip=185.136.64.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=siemens.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rts-flowmailer.siemens.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=siemens.com header.i=diogo.ivo@siemens.com header.b="NGwz4KAY" Received: by mta-64-225.siemens.flowmailer.net with ESMTPSA id 20240603100505208541b00a127fca79 for ; Mon, 03 Jun 2024 12:05:06 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm2; d=siemens.com; i=diogo.ivo@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=MxB6k1sco2UHJP14v2p5mkih6Wnxt16euSuPKKxerCQ=; b=NGwz4KAYzVkMSPgmmg7rYaR5uYHyGG30+RbiBGeTBHWQ65RYxCtCBkpgPdme6jdBZ6J9Ii 3gK2iD04MWey5MWGYArFAdS7L6eENSEzxOOmJB0pTXg1JoAUupgo/9ohd7uAxZPqD/PLAKKi 1RMHnd4SjzYy7trMxrH4RyfImfukU=; Message-ID: <171516c6-71a8-4dbb-bf6d-d20cfb55686f@siemens.com> Date: Mon, 3 Jun 2024 11:05:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 1/3] net: ti: icssg-prueth: Enable PTP timestamping support for SR1.0 devices To: Simon Horman Cc: MD Danish Anwar , Roger Quadros , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jan Kiszka , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20240529-iep-v1-0-7273c07592d3@siemens.com> <20240529-iep-v1-1-7273c07592d3@siemens.com> <20240601120334.GF491852@kernel.org> Content-Language: en-US From: Diogo Ivo In-Reply-To: <20240601120334.GF491852@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1320519:519-21489:flowmailer Hi Simon, On 6/1/24 1:03 PM, Simon Horman wrote: > On Wed, May 29, 2024 at 05:05:10PM +0100, Diogo Ivo wrote: >> + prueth->iep0 = icss_iep_get_idx(np, 0); >> + if (IS_ERR(prueth->iep0)) { >> + ret = dev_err_probe(dev, PTR_ERR(prueth->iep0), "iep0 get failed\n"); > > Hi Diogo, > > A minor nit from my side. > No need to address this unless there will be a v2 for some other reason. > > Networking still prefers code to be 80 columns wide or less. > It looks like that can be trivially achieved here. Noted :) Since I already have to address Sunil's comments on patch 2 I'll change this one too to comply with the 80 character rule. Thank you for the review! Best regards, Diogo