mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Mariel Tinaco <Mariel.Tinaco@analog.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Michael Hennerich <Michael.Hennerich@analog.com>,
	 Dimitri Fedrau <dima.fedrau@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	 Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org,  Jonathan Cameron <jic23@kernel.org>,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>,
	 Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
	 Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: dac: add docs for ad8460
Date: Fri, 10 May 2024 02:21:23 -0500	[thread overview]
Message-ID: <171532568373.3099714.15391241523800053923.robh@kernel.org> (raw)
In-Reply-To: <20240510064053.278257-2-Mariel.Tinaco@analog.com>


On Fri, 10 May 2024 14:40:52 +0800, Mariel Tinaco wrote:
> This adds the bindings documentation for the 14-bit
> High Voltage, High Current, Waveform Generator
> Digital-to-Analog converter.
> 
> Signed-off-by: Mariel Tinaco <Mariel.Tinaco@analog.com>
> ---
>  .../bindings/iio/dac/adi,ad8460.yaml          | 67 +++++++++++++++++++
>  MAINTAINERS                                   |  7 ++
>  2 files changed, 74 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad8460.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/iio/dac/adi,ad8460.example.dts:22.17-27: Warning (reg_format): /example-0/spi/dac@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
Documentation/devicetree/bindings/iio/dac/adi,ad8460.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/dac/adi,ad8460.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/dac/adi,ad8460.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/dac/adi,ad8460.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/dac/adi,ad8460.example.dts:19.13-29.11: Warning (spi_bus_bridge): /example-0/spi: incorrect #address-cells for SPI bus
Documentation/devicetree/bindings/iio/dac/adi,ad8460.example.dts:19.13-29.11: Warning (spi_bus_bridge): /example-0/spi: incorrect #size-cells for SPI bus
Documentation/devicetree/bindings/iio/dac/adi,ad8460.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/dac/adi,ad8460.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge'
Documentation/devicetree/bindings/iio/dac/adi,ad8460.example.dts:20.19-28.15: Warning (avoid_default_addr_size): /example-0/spi/dac@0: Relying on default #address-cells value
Documentation/devicetree/bindings/iio/dac/adi,ad8460.example.dts:20.19-28.15: Warning (avoid_default_addr_size): /example-0/spi/dac@0: Relying on default #size-cells value
Documentation/devicetree/bindings/iio/dac/adi,ad8460.example.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size'

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240510064053.278257-2-Mariel.Tinaco@analog.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-05-10  7:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10  6:40 [PATCH 0/2] add AD8460 DAC driver Mariel Tinaco
2024-05-10  6:40 ` [PATCH 1/2] dt-bindings: iio: dac: add docs for ad8460 Mariel Tinaco
2024-05-10  7:21   ` Rob Herring (Arm) [this message]
2024-05-10 17:28   ` David Lechner
2024-05-11 16:25     ` Jonathan Cameron
2024-05-11 18:47       ` David Lechner
2024-05-21  7:07         ` Nuno Sá
2024-06-24  4:20       ` Tinaco, Mariel
2024-05-10  6:40 ` [PATCH 2/2] iio: dac: support the ad8460 Waveform DAC Mariel Tinaco
2024-05-10 17:30   ` David Lechner
2024-05-11 16:44   ` Jonathan Cameron
2024-06-24  4:19     ` Tinaco, Mariel
2024-06-28 18:45       ` Jonathan Cameron
2024-07-08  5:17         ` Tinaco, Mariel
2024-07-08 16:05           ` Jonathan Cameron
2024-07-11  9:20             ` Nuno Sá
2024-07-11 21:31               ` David Lechner
2024-07-12  6:57                 ` Nuno Sá
2024-07-13  9:57                   ` Jonathan Cameron
2024-07-14  6:17                     ` Nuno Sá
2024-06-24  4:56     ` Tinaco, Mariel
2024-06-28 18:51       ` Jonathan Cameron
2024-07-07 23:32         ` Tinaco, Mariel
2024-07-07 23:37           ` Tinaco, Mariel
2024-05-10 17:30 ` [PATCH 0/2] add AD8460 DAC driver David Lechner
2024-05-11 16:21   ` Jonathan Cameron
2024-06-24  4:38     ` Tinaco, Mariel
2024-06-28 18:39       ` Jonathan Cameron
2024-07-07 23:29         ` Tinaco, Mariel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171532568373.3099714.15391241523800053923.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Mariel.Tinaco@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dima.fedrau@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marcelo.schmitt1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®