mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Aryabhatta Dey <aryabhattadey35@gmail.com>
Cc: skhan@linuxfoundation.org, linux-sound@vger.kernel.org,
	 lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	conor+dt@kernel.org,  devicetree@vger.kernel.org,
	javier.carrasco.cruz@gmail.com,  krzk+dt@kernel.org,
	broonie@kernel.org
Subject: Re: [RFC PATCH] ASoC: dt-bindings: alc5623: convert to dt schema
Date: Sat, 11 May 2024 00:24:32 -0500	[thread overview]
Message-ID: <171540507205.1412542.3948533586469324311.robh@kernel.org> (raw)
In-Reply-To: <j2f5m3lydlkipt3vnyikeoq5bx6tsf6z22ljpspcgtnohy65on@htyjjd3ojkde>


On Sat, 11 May 2024 10:11:24 +0530, Aryabhatta Dey wrote:
> Convert Documentation/bindings/devicetree/alc5623.txt to yaml.
> 
> First attempt at a dt schema conversion patch.
> Checked the yaml file with make dt_binding_check and make CHECK_DTBS=y.
> Only warning being produced is
> Documentation/devicetree/bindings/net/snps,dwmac.yaml: mac-mode: missing type definition
> Not sure how I should handle this.
> 
> Signed-off-by: Aryabhatta Dey <aryabhattadey35@gmail.com>
> ---
>  .../devicetree/bindings/sound/alc5623.txt     | 25 ----------
>  .../bindings/sound/realtek,alc5623.yaml       | 48 +++++++++++++++++++
>  2 files changed, 48 insertions(+), 25 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/alc5623.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/realtek,alc5623.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/realtek,alc5623.example.dtb: codec@1a: '#gpio-cells' is a required property
	from schema $id: http://devicetree.org/schemas/sound/realtek,alc5632.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/realtek,alc5623.example.dtb: codec@1a: 'gpio-controller' is a required property
	from schema $id: http://devicetree.org/schemas/sound/realtek,alc5632.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/realtek,alc5623.example.dtb: codec@1a: 'add-ctrl', 'jack-det-ctrl' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/sound/realtek,alc5632.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/j2f5m3lydlkipt3vnyikeoq5bx6tsf6z22ljpspcgtnohy65on@htyjjd3ojkde

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


      reply	other threads:[~2024-05-11  5:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-11  4:41 Aryabhatta Dey
2024-05-11  5:24 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171540507205.1412542.3948533586469324311.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=aryabhattadey35@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®