From: "Rob Herring (Arm)" <robh@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: joel@jms.id.au, krzk+dt@kernel.org, devicetree@vger.kernel.org,
linux-fsi@lists.ozlabs.org, andrew@codeconstruct.com.au,
conor+dt@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/9] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes
Date: Tue, 14 May 2024 17:35:49 -0500 [thread overview]
Message-ID: <171572614925.2391901.12172648988051515568.robh@kernel.org> (raw)
In-Reply-To: <20240514195435.155372-2-eajames@linux.ibm.com>
On Tue, 14 May 2024 14:54:27 -0500, Eddie James wrote:
> The FSI2SPI bridge has several SPI controllers behind it, which
> should be documented. Also, therefore the node needs to specify
> address and size cells.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Depends on https://lore.kernel.org/all/20240514192630.152747-1-eajames@linux.ibm.com/
>
> .../devicetree/bindings/fsi/ibm,fsi2spi.yaml | 36 ++++++++++++++++---
> 1 file changed, 32 insertions(+), 4 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml:
Error in referenced schema matching $id: http://devicetree.org/schemas/spi/ibm,spi-fsi.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.example.dtb: fsi2spi@1c00: spi@0: False schema does not allow {'compatible': ['ibm,spi-fsi'], 'reg': [[0]], '#address-cells': [[1]], '#size-cells': [[0]], 'eeprom@0': {'compatible': ['atmel,at25'], 'reg': [[0]], 'address-width': [[24]], 'pagesize': [[256]], 'size': [[524288]], 'spi-max-frequency': [[1000000]]}}
from schema $id: http://devicetree.org/schemas/fsi/ibm,fsi2spi.yaml#
Documentation/devicetree/bindings/fsi/ibm,fsi2spi.example.dtb: /example-0/fsi2spi@1c00/spi@0: failed to match any schema with compatible: ['ibm,spi-fsi']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240514195435.155372-2-eajames@linux.ibm.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-05-14 22:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 19:54 [PATCH v5 0/9] dt-bindings: fsi: Convert to json-schema and add missing engines Eddie James
2024-05-14 19:54 ` [PATCH v5 1/9] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes Eddie James
2024-05-14 22:35 ` Rob Herring (Arm) [this message]
2024-05-15 8:14 ` Krzysztof Kozlowski
2024-05-15 13:06 ` Eddie James
2024-05-15 14:12 ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 2/9] dt-bindings: fsi: Document the IBM SCOM engine Eddie James
2024-05-14 19:54 ` [PATCH v5 3/9] dt-bindings: fsi: p9-occ: Convert to json-schema Eddie James
2024-05-15 8:14 ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 4/9] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-05-14 19:54 ` [PATCH v5 5/9] dt-bindings: fsi: Document the FSI controller common properties Eddie James
2024-05-15 14:18 ` Krzysztof Kozlowski
2024-05-15 14:28 ` Eddie James
2024-05-15 14:35 ` Krzysztof Kozlowski
2024-05-15 15:02 ` Eddie James
2024-05-17 9:17 ` Krzysztof Kozlowski
2024-05-22 14:39 ` Rob Herring
2024-05-14 19:54 ` [PATCH v5 6/9] dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller Eddie James
2024-05-14 19:54 ` [PATCH v5 7/9] dt-bindings: fsi: ast2600-fsi-master: Convert to json-schema Eddie James
2024-05-15 14:21 ` Krzysztof Kozlowski
2024-05-15 14:24 ` Eddie James
2024-05-15 14:29 ` Krzysztof Kozlowski
2024-05-15 14:29 ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 8/9] dt-bindings: fsi: Document the AST2700 FSI master Eddie James
2024-05-15 14:21 ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 9/9] dt-bindings: fsi: Document the FSI Hub Controller Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171572614925.2391901.12172648988051515568.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®