From: Kalle Valo <kvalo@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: horms@kernel.org, Jeff Johnson <jjohnson@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
linux-wireless@vger.kernel.org (open list:NETWORKING DRIVERS
(WIRELESS)),
ath11k@lists.infradead.org (open list:QUALCOMM ATHEROS ATH11K
WIRELESS DRIVER), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH wireless-next] ath11k: Fix error path in ath11k_pcic_ext_irq_config
Date: Fri, 17 May 2024 06:55:05 +0000 (UTC) [thread overview]
Message-ID: <171592890381.3197586.18328283621008534575.kvalo@kernel.org> (raw)
In-Reply-To: <20240508185902.70975-1-leitao@debian.org>
Breno Leitao <leitao@debian.org> wrote:
> If one of the dummy allocation fails in ath11k_pcic_ext_irq_config(),
> the previous allocated devices might leak due to returning without
> deallocating the devices.
>
> Instead of returning on the error path, deallocate all the previously
> allocated net_devices and then return.
>
> Fixes: bca592ead825 ("wifi: ath11k: allocate dummy net_device dynamically")
> Signed-off-by: Breno Leitao <leitao@debian.org>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-current branch of ath.git, thanks.
637c435f08ea wifi: ath11k: Fix error path in ath11k_pcic_ext_irq_config
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240508185902.70975-1-leitao@debian.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-05-17 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 18:59 Breno Leitao
2024-05-10 11:56 ` Simon Horman
2024-05-14 13:24 ` Kalle Valo
2024-05-14 13:51 ` Jakub Kicinski
2024-05-17 6:55 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171592890381.3197586.18328283621008534575.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=horms@kernel.org \
--cc=jjohnson@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®