From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751568AbbIGNQn (ORCPT ); Mon, 7 Sep 2015 09:16:43 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:54418 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbbIGNQj (ORCPT ); Mon, 7 Sep 2015 09:16:39 -0400 From: Arnd Bergmann To: Palmer Dabbelt Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Remove #ifdef CONFIG_64BIT from all asm-generic/fcntl.h Date: Mon, 07 Sep 2015 15:16:37 +0200 Message-ID: <17166105.3lntxUsXFt@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1441152610-22566-1-git-send-email-palmer@dabbelt.com> References: <1441152610-22566-1-git-send-email-palmer@dabbelt.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:DXyT0eFoJVkwvVC/AwPPrAnhJ4FQihXPPfAcClU7/sc5cG+bdPv pJJd2BGyuQSGiqxU22Kkr4ICPMEZKT6clEmxaSmhCHVIq85xxFotrN1LFks9Sj1XDsUkRZq HsJk3K69hJDKGT6mIbxocS56zLRL1VXtQuJIUEbzwWuWvumQth61ekrFRHNq1CkThl/5owX hd+xG0eZh2P/G8GZoTEyQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:UKGJW8vPxEU=:j3aNPST3UR6skgoFGFwxBj uVk3tlgwroBUzy2I6SatE2HzXY/qcSG5JBy7s1ZGsxYJXCwDHoBicWfbDliWonuFBCXS8PTQJ l4reqVRjj7SYlpz+6Hzk5UTtthchcs05N4KQobRIThCTlta1hTTiT9ffMrZH4boCMIXmcxk+6 GS1QX2L/TzbDxTOkla9VXJsd5KIa3qxyM0WucNs2uQdb46ipz5Y2YziiorSx7h7mijJElBLdf /az/ICAExUzr/2LLx+hbvZUeTK+oD34eJ3Goh+4N5GLcsGD/godzcOWWcohioeruBY9TnwxFH Res+lDyVKvW01wmo10toqEmOF9t6tPM6sW2x5rX6js3uf5QZKBUeyBQNqhit3dbrGH4hUrcE+ diHiry3jgGbpw1cSpVThUT0/Z/+1H5hJQ3+fPnhYsn9NqrbK3PWoNcthM+yGW/WTTtjaITL+l 7IL2wHXxFa8h1MA2ujbBxp/Qnv1YGNucBMmcl8td5WR19s8DBYfrmTYBw31k7e+SZx+ooZDuj asvYeKI7v8RJbphI9qN2+QMJ4nfEjxWKKnG13+C96k8ArE0MMqiAexhyQm5dnPO8n/llv1vXI CIhB2JuRbtJ2MP7O0hDiJ8Umh5ntPhF9IZrmMDA+CUksKVL5qz5LDYJ9KE9EQJ198aG4bbGWK L5LnUkvB/tLnxgbXTFgWJzcA4MO0KjNlSzLa4XB4ipsQclf4ZgUuNWsgIrEUZPqM57MILX/nQ 5LvRlbSzdT3wUsqV Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 01 September 2015 17:10:10 Palmer Dabbelt wrote: > From: Palmer Dabbelt > > When working on the RISC-V port I noticed that F_SETLK64 was being > defined on our 64-bit platform, despite our port being so new that > we've only ever had the 64-bit file ops. Since there's not compat > layer for these, this causes fcntl to bail out. > > It turns out that one of the ways in with F_SETLK64 was being defined > (there's some more in glibc, but that's a whole different story... :)) > is the result of CONFIG_64BIT showing up in this user-visible header. > confirms this isn't sane, so I replaced it > with a __BITS_PER_LONG check. > > I went ahead and grep'd for any more of these (with > headers_install_all), and this was the only one I found. > > Signed-off-by: Palmer Dabbelt > Reviewed-by: Andrew Waterman > Reviewed-by: Albert Ou Looks good to me. Are you planning to submit the RISC-V port upstream any time soon? If so, just keep the patch in your tree and add my Acked-by: Arnd Bergmann However, I did see a lot of similar bugs now that you point me to it: $ grep -r \\\