From: "Rob Herring (Arm)" <robh@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Saravana Kannan <saravanak@google.com>,
Anup Patel <apatel@ventanamicro.com>
Subject: Re: [PATCH] of: property: Fix fw_devlink handling of interrupt-map
Date: Tue, 28 May 2024 12:14:44 -0500 [thread overview]
Message-ID: <171691641513.1016774.9157485411952411160.robh@kernel.org> (raw)
In-Reply-To: <20240528164132.2451685-1-maz@kernel.org>
On Tue, 28 May 2024 17:41:32 +0100, Marc Zyngier wrote:
> Commit d976c6f4b32c ("of: property: Add fw_devlink support for
> interrupt-map property") tried to do what it says on the tin,
> but failed on a couple of points:
>
> - it confuses bytes and cells. Not a huge deal, except when it
> comes to pointer arithmetic
>
> - it doesn't really handle anything but interrupt-maps that have
> their parent #address-cells set to 0
>
> The combinations of the two leads to some serious fun on my M1
> box, with plenty of WARN-ON() firing all over the shop, and
> amusing values being generated for interrupt specifiers.
>
> Address both issues so that I can boot my machines again.
>
> Fixes: d976c6f4b32c ("of: property: Add fw_devlink support for interrupt-map property")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Cc: Anup Patel <apatel@ventanamicro.com>
> Cc: Saravana Kannan <saravanak@google.com>
> Cc: Rob Herring (Arm) <robh@kernel.org>
> ---
> drivers/of/property.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
Applied, thanks!
next prev parent reply other threads:[~2024-05-28 17:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 16:41 Marc Zyngier
2024-05-28 17:14 ` Rob Herring (Arm) [this message]
2024-05-28 17:23 ` Saravana Kannan
2024-05-29 5:15 ` Anup Patel
2024-05-29 6:33 ` Marc Zyngier
2024-05-29 10:16 ` Anup Patel
2024-05-29 10:44 ` Marc Zyngier
2024-05-29 11:28 ` Anup Patel
2024-05-29 12:00 ` Marc Zyngier
2024-05-29 15:17 ` Conor Dooley
2024-05-29 16:37 ` Anup Patel
2024-05-29 13:51 ` Rob Herring
2024-05-29 16:46 ` Rob Herring
2024-05-29 13:44 ` Rob Herring
2024-05-29 14:00 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171691641513.1016774.9157485411952411160.robh@kernel.org \
--to=robh@kernel.org \
--cc=apatel@ventanamicro.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®