From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] tools api io: Move filling the io buffer to its own function
Date: Fri, 31 May 2024 14:14:03 -0700 [thread overview]
Message-ID: <171718991317.2179562.7793120859292708141.b4-ty@kernel.org> (raw)
In-Reply-To: <20240519181716.4088459-1-irogers@google.com>
On Sun, 19 May 2024 11:17:16 -0700, Ian Rogers wrote:
> In general a read fills 4kb so filling the buffer is a 1 in 4096
> operation, move it out of the io__get_char function to avoid some
> checking overhead and to better hint the function is good to inline.
>
> For perf's IO intensive internal (non-rigorous) benchmarks there's a
> near 8% improvement to kallsyms-parsing with a default build.
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
--
Namhyung Kim <namhyung@kernel.org>
prev parent reply other threads:[~2024-05-31 21:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-19 18:17 Ian Rogers
2024-05-23 23:25 ` Namhyung Kim
2024-05-24 4:47 ` Ian Rogers
2024-05-30 16:44 ` Namhyung Kim
2024-05-30 17:01 ` Ian Rogers
2024-05-30 17:07 ` Namhyung Kim
2024-05-31 21:14 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171718991317.2179562.7793120859292708141.b4-ty@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@redhat.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®