From: Jens Axboe <axboe@kernel.dk>
To: Andreas Hindborg <nmi@metaspace.dk>
Cc: Andreas Hindborg <a.hindborg@samsung.com>,
Keith Busch <kbusch@kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
John Garry <john.g.garry@oracle.com>,
Damien Le Moal <dlemoal@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] null_blk: fix validation of block size
Date: Tue, 04 Jun 2024 08:17:19 -0600 [thread overview]
Message-ID: <171751063982.375344.56104601455563821.b4-ty@kernel.dk> (raw)
In-Reply-To: <20240603192645.977968-1-nmi@metaspace.dk>
On Mon, 03 Jun 2024 21:26:45 +0200, Andreas Hindborg wrote:
> Block size should be between 512 and PAGE_SIZE and be a power of 2. The current
> check does not validate this, so update the check.
>
> Without this patch, null_blk would Oops due to a null pointer deref when
> loaded with bs=1536 [1].
>
> Link: https://lore.kernel.org/all/87wmn8mocd.fsf@metaspace.dk/
>
> [...]
Applied, thanks!
[1/1] null_blk: fix validation of block size
commit: 237e061865aa5a24c2cd960c4feb2904c8736a75
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-06-04 14:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 19:26 Andreas Hindborg
2024-06-03 19:47 ` Keith Busch
2024-06-04 4:46 ` Christoph Hellwig
2024-06-28 14:30 ` John Garry
2024-06-29 5:07 ` Christoph Hellwig
2024-07-03 12:20 ` blk_validate_limits validation of block size (was Re: [PATCH v2] null_blk: fix validation of block size) John Garry
2024-07-03 13:19 ` Christoph Hellwig
2024-07-03 17:28 ` John Garry
2024-07-04 6:18 ` Christoph Hellwig
2024-06-04 1:27 ` [PATCH v2] null_blk: fix validation of block size Ming Lei
2024-06-04 14:17 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171751063982.375344.56104601455563821.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=a.hindborg@samsung.com \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nmi@metaspace.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®