From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Lyndon Sanche" <lsanche@lyndeno.ca>,
"Hans de Goede" <hdegoede@redhat.com>,
"Thomas Weißschuh" <linux@weissschuh.net>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: dell-pc: avoid double free and invalid unregistration
Date: Fri, 07 Jun 2024 16:22:45 +0300 [thread overview]
Message-ID: <171776656561.2612.17760986388744096307.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20240604-dell-pc-double-free-v1-1-6d81255b2a44@weissschuh.net>
On Tue, 04 Jun 2024 23:41:24 +0200, Thomas Weißschuh wrote:
> If platform_profile_register() fails it does kfree(thermal_handler) and
> leaves the pointer value around.
> Any call to thermal_cleanup() will try to kfree(thermal_handler) again.
> This will happen right away in dell_init().
> In addition, platform_profile_remove() will be called although no
> profile is registered.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: dell-pc: avoid double free and invalid unregistration
commit: dd637f5cd5f334d2d014872544470031415cec3b
--
i.
prev parent reply other threads:[~2024-06-07 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 21:41 Thomas Weißschuh
2024-06-05 2:46 ` Lyndon Sanche
2024-06-07 13:22 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171776656561.2612.17760986388744096307.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=lsanche@lyndeno.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®