From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stefan Wahren <wahrenst@gmx.net>,
Umang Jain <umang.jain@ideasonboard.com>,
linux-rpi-kernel@lists.infradead.org
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Dave Stevenson <dave.stevenson@raspberrypi.org>,
detule <ogjoneski@gmail.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE
<linux-arm-kernel@lists.infradead.org>,
open list:STAGING SUBSYSTEM <linux-staging@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>;
Subject: Re: [v2 PATCH] staging: vc04_services: vchiq_arm: Fix initialisation check
Date: Fri, 14 Jun 2024 12:31:06 +0100 [thread overview]
Message-ID: <171836466631.2248009.16741779932900773222@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <37779db2-114c-4df6-97fd-2444bdad5529@gmx.net>
Quoting Stefan Wahren (2024-06-14 12:00:38)
> Hi Kieran,
>
> Am 14.06.24 um 12:43 schrieb Kieran Bingham:
> > The vchiq_state used to be obtained through an accessor
> > which would validate that the VCHIQ had been initialised
> > correctly with the remote.
> >
> > In commit 42a2f6664e18 ("staging: vc04_services: Move global g_state to
> > vchiq_state") the global state was moved to the vchiq_mgnt structures
> > stored as a vchiq instance specific context. This conversion removed the
> > helpers and instead replaced users of this helper with the assumption
> > that the state is always available and the remote connected.
> >
> > Fix this broken assumption by re-introducing the logic that was lost
> > during the conversion.
> >
> > Fixes: 42a2f6664e18 ("staging: vc04_services: Move global g_state to vchiq_state")
> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> > ---
> > v2:
> > - No change, just resend
> what happen to my comments for the first version?
Err ... i missed them ... let me go back and look!
--
Kieran
next prev parent reply other threads:[~2024-06-14 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 10:43 Kieran Bingham
2024-06-14 11:00 ` Stefan Wahren
2024-06-14 11:31 ` Kieran Bingham [this message]
2024-06-20 16:59 ` Stefan Wahren
2024-06-20 22:11 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171836466631.2248009.16741779932900773222@ping.linuxembedded.co.uk \
--to=kieran.bingham@ideasonboard.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@linaro.org \
--cc=dave.stevenson@raspberrypi.org \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=ogjoneski@gmail.com \
--cc=umang.jain@ideasonboard.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®