From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Cyril Hrubis <chrubis@suse.cz>
Cc: Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v2] loop: Disable fallocate() zero and discard if not supported
Date: Fri, 14 Jun 2024 06:21:36 -0600 [thread overview]
Message-ID: <171836769633.229112.12813343173922846778.b4-ty@kernel.dk> (raw)
In-Reply-To: <20240613163817.22640-1-chrubis@suse.cz>
On Thu, 13 Jun 2024 18:38:17 +0200, Cyril Hrubis wrote:
> If fallcate is implemented but zero and discard operations are not
> supported by the filesystem the backing file is on we continue to fill
> dmesg with errors from the blk_mq_end_request() since each time we call
> fallocate() on the loop device the EOPNOTSUPP error from lo_fallocate()
> ends up propagated into the block layer. In the end syscall succeeds
> since the blkdev_issue_zeroout() falls back to writing zeroes which
> makes the errors even more misleading and confusing.
>
> [...]
Applied, thanks!
[1/1] loop: Disable fallocate() zero and discard if not supported
commit: 5f75e081ab5cbfbe7aca2112a802e69576ee9778
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-06-14 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 16:38 Cyril Hrubis
2024-06-13 17:11 ` Christoph Hellwig
2024-06-14 11:21 ` Jan Kara
2024-06-14 12:21 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171836769633.229112.12813343173922846778.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=chrubis@suse.cz \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®