mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Charles Wang <charles.goodix@gmail.com>
Cc: dan.carpenter@linaro.org, jikos@kernel.org,
	 linux-kernel@vger.kernel.org, krzk+dt@kernel.org,
	 devicetree@vger.kernel.org, linux-input@vger.kernel.org,
	bentiss@kernel.org,  hbarnor@chromium.org, dianders@chromium.org,
	dmitry.torokhov@gmail.com
Subject: Re: [PATCH v4 2/2] dt-bindings: input: Goodix SPI HID Touchscreen
Date: Fri, 14 Jun 2024 07:13:46 -0600	[thread overview]
Message-ID: <171837082626.626508.10284320881127428760.robh@kernel.org> (raw)
In-Reply-To: <20240614121538.236727-3-charles.goodix@gmail.com>


On Fri, 14 Jun 2024 20:15:38 +0800, Charles Wang wrote:
> The Goodix GT7986U touch controller report touch data according to the
> HID protocol through the SPI bus. However, it is incompatible with
> Microsoft's HID-over-SPI protocol.
> 
> Signed-off-by: Charles Wang <charles.goodix@gmail.com>
> ---
>  .../bindings/input/goodix,gt7986u.yaml        | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/goodix,gt7986u.example.dtb: touchscreen@0: 'spi-max-frequency' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/input/goodix,gt7986u.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240614121538.236727-3-charles.goodix@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-06-14 13:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-14 12:15 [PATCH v4 0/2] HID: add initial support for Goodix HID-over-SPI touchscreen Charles Wang
2024-06-14 12:15 ` [PATCH v4 1/2] HID: hid-goodix: Add Goodix HID-over-SPI driver Charles Wang
2024-06-15 11:57   ` kernel test robot
2024-06-15 18:03   ` kernel test robot
2024-06-16 23:10   ` kernel test robot
2024-06-14 12:15 ` [PATCH v4 2/2] dt-bindings: input: Goodix SPI HID Touchscreen Charles Wang
2024-06-14 13:13   ` Rob Herring (Arm) [this message]
2024-06-14 15:26   ` Conor Dooley
2024-06-18  7:15     ` Charles Wang
2024-06-14 15:27   ` Conor Dooley
2024-06-18  7:27     ` Charles Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171837082626.626508.10284320881127428760.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bentiss@kernel.org \
    --cc=charles.goodix@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hbarnor@chromium.org \
    --cc=jikos@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®