From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
laurent.pinchart@ideasonboard.com
Cc: airlied@gmail.com, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] drm: Remove unused function rcar_cmm_write
Date: Wed, 19 Jun 2024 10:24:34 +0100 [thread overview]
Message-ID: <171878907461.2248009.5135990660675548248@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <20240619075436.86407-1-jiapeng.chong@linux.alibaba.com>
Quoting Jiapeng Chong (2024-06-19 08:54:36)
> The function are defined in the rcar_cmm.c file, but not called
> elsewhere, so delete the unused function.
>
> drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function 'rcar_cmm_read'.
Indeed it's unused.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9364
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
> index 26a2f5ad8ee5..883b960e9acc 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c
> @@ -32,11 +32,6 @@ struct rcar_cmm {
> } lut;
> };
>
> -static inline int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg)
> -{
> - return ioread32(rcmm->base + reg);
> -}
> -
> static inline void rcar_cmm_write(struct rcar_cmm *rcmm, u32 reg, u32 data)
> {
> iowrite32(data, rcmm->base + reg);
> --
> 2.20.1.7.g153144c
>
prev parent reply other threads:[~2024-06-19 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 7:54 Jiapeng Chong
2024-06-19 9:16 ` Sergey Shtylyov
2024-06-19 16:53 ` Laurent Pinchart
2024-06-19 9:24 ` Kieran Bingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171878907461.2248009.5135990660675548248@ping.linuxembedded.co.uk \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=abaci@linux.alibaba.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®