mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Yang Chen <yangchen.openbmc@gmail.com>
Cc: andrew@codeconstruct.com.au, patrick@stwcx.xyz, joel@jms.id.au,
	 linux-arm-kernel@lists.infradead.org, Jerry.Lin@quantatw.com,
	 linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	 devicetree@vger.kernel.org
Subject: Re: [PATCH 00/17] Revise Facebook Minerva BMC DTS
Date: Wed, 26 Jun 2024 07:31:29 -0600	[thread overview]
Message-ID: <171940832692.2961326.910026599869370818.robh@kernel.org> (raw)
In-Reply-To: <20240625121835.751013-1-yangchen.openbmc@gmail.com>


On Tue, 25 Jun 2024 20:18:18 +0800, Yang Chen wrote:
> Revise the Linux device tree entry related to Facebook platform Minerva
> specific devices connected to the Aspeed AST2600 BMC.
> 
> Yang Chen (17):
>   ARM: dts: aspeed: minerva: change the address of tmp75
>   ARM: dts: aspeed: minerva: Add spi-gpio
>   ARM: dts: aspeed: minerva: change aliases for uart
>   ARM: dts: aspeed: minerva: add eeprom on i2c bus
>   ARM: dts: aspeed: minerva: change RTC reference
>   ARM: dts: aspeed: minerva: enable mdio3
>   ARM: dts: aspeed: minerva: remove unused bus and device
>   ARM: dts: aspeed: minerva: Define the LEDs node name
>   ARM: dts: aspeed: minerva: Add adc sensors for fan board
>   ARM: dts: aspeed: minerva: add linename of two pins
>   ARM: dts: aspeed: minerva: enable ehci0 for USB
>   ARM: dts: aspeed: minerva: add tmp75 sensor
>   ARM: dts: minerva: add power monitor xdp710
>   ARM: dts: aspeed: minerva: revise sgpio line name
>   ARM: dts: aspeed: minerva: Switch the i2c bus number
>   ARM: dts: aspeed: minerva: remove unused power device
>   ARM: dts: aspeed: minerva: add ltc4287 device
> 
>  .../aspeed/aspeed-bmc-facebook-minerva.dts    | 516 +++++++++++++-----
>  1 file changed, 373 insertions(+), 143 deletions(-)
> 
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-facebook-minerva.dtb' for 20240625121835.751013-1-yangchen.openbmc@gmail.com:

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dtb: /: spi-gpio: {'status': ['okay'], 'compatible': ['spi-gpio'], '#address-cells': 1, '#size-cells': 0, 'gpio-sck': [61, 203, 0], 'gpio-mosi': [61, 204, 0], 'gpio-miso': [61, 205, 0], 'num-chipselects': 1, 'cs-gpios': [[61, 200, 1]], 'tpmdev@0': {'compatible': ['infineon,slb9670', 'tcg,tpm_tis-spi'], 'spi-max-frequency': 33000000, 'reg': [[0]]}} is not of type 'array'
	from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dtb: spi-gpio: $nodename:0: 'spi-gpio' does not match '^spi(@.*|-([0-9]|[1-9][0-9]+))?$'
	from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dtb: spi-gpio: gpio-sck: False schema does not allow [61, 203, 0]
	from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dtb: spi-gpio: gpio-miso: False schema does not allow [61, 205, 0]
	from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dtb: spi-gpio: gpio-mosi: False schema does not allow [61, 204, 0]
	from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dtb: spi-gpio: 'sck-gpios' is a required property
	from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dtb: spi-gpio: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'gpio-miso', 'gpio-mosi', 'gpio-sck', 'tpmdev@0' were unexpected)
	from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva.dtb: tpmdev@0: $nodename:0: 'tpmdev@0' does not match '^tpm(@[0-9a-f]+)?$'
	from schema $id: http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml#






      parent reply	other threads:[~2024-06-26 13:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 12:18 Yang Chen
2024-06-25 12:18 ` [PATCH 01/17] ARM: dts: aspeed: minerva: change the address of tmp75 Yang Chen
2024-06-25 12:18 ` [PATCH 02/17] ARM: dts: aspeed: minerva: Add spi-gpio Yang Chen
2024-06-26  1:30   ` Andrew Jeffery
2024-06-25 12:18 ` [PATCH 03/17] ARM: dts: aspeed: minerva: change aliases for uart Yang Chen
2024-06-25 12:18 ` [PATCH 04/17] ARM: dts: aspeed: minerva: add eeprom on i2c bus Yang Chen
2024-06-25 12:18 ` [PATCH 05/17] ARM: dts: aspeed: minerva: change RTC reference Yang Chen
2024-06-25 12:18 ` [PATCH 06/17] ARM: dts: aspeed: minerva: enable mdio3 Yang Chen
2024-06-25 12:18 ` [PATCH 07/17] ARM: dts: aspeed: minerva: remove unused bus and device Yang Chen
2024-06-25 12:18 ` [PATCH 08/17] ARM: dts: aspeed: minerva: Define the LEDs node name Yang Chen
2024-06-25 12:18 ` [PATCH 09/17] ARM: dts: aspeed: minerva: Add adc sensors for fan board Yang Chen
2024-06-25 12:18 ` [PATCH 10/17] ARM: dts: aspeed: minerva: add linename of two pins Yang Chen
2024-06-25 12:18 ` [PATCH 11/17] ARM: dts: aspeed: minerva: enable ehci0 for USB Yang Chen
2024-06-25 12:18 ` [PATCH 12/17] ARM: dts: aspeed: minerva: add tmp75 sensor Yang Chen
2024-06-25 12:18 ` [PATCH 13/17] ARM: dts: minerva: add power monitor xdp710 Yang Chen
2024-06-25 12:18 ` [PATCH 14/17] ARM: dts: aspeed: minerva: revise sgpio line name Yang Chen
2024-06-25 12:18 ` [PATCH 15/17] ARM: dts: aspeed: minerva: Switch the i2c bus number Yang Chen
2024-06-25 12:18 ` [PATCH 16/17] ARM: dts: aspeed: minerva: remove unused power device Yang Chen
2024-06-25 12:18 ` [PATCH 17/17] ARM: dts: aspeed: minerva: add ltc4287 device Yang Chen
2024-06-26 13:31 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171940832692.2961326.910026599869370818.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Jerry.Lin@quantatw.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick@stwcx.xyz \
    --cc=yangchen.openbmc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®