mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
	 Miaoqian Lin <linmq006@gmail.com>,
	 Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
	"Hervé Codina" <herve.codina@bootlin.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: (subset) [PATCH v2] Revert "leds: led-core: Fix refcount leak in of_led_get()"
Date: Thu, 27 Jun 2024 09:09:27 +0100	[thread overview]
Message-ID: <171947576772.2875250.15838690035445924875.b4-ty@kernel.org> (raw)
In-Reply-To: <20240625-led-class-device-leak-v2-1-75fdccf47421@bootlin.com>

On Tue, 25 Jun 2024 10:34:38 +0200, Luca Ceresoli wrote:
> This reverts commit da1afe8e6099980fe1e2fd7436dca284af9d3f29.
> 
> Commit 699a8c7c4bd3 ("leds: Add of_led_get() and led_put()"), introduced in
> 5.5, added of_led_get() and led_put() but missed a put_device() in
> led_put(), thus creating a leak in case the consumer device is removed.
> 
> Arguably device removal was not very popular, so this went apparently
> unnoticed until 2022. In January 2023 two different patches got merged to
> fix the same bug:
> 
> [...]

Applied, thanks!

[1/1] Revert "leds: led-core: Fix refcount leak in of_led_get()"
      commit: 940b27161afc6ec53fc66245a4fb3518394cdc92

--
Lee Jones [李琼斯]


      reply	other threads:[~2024-06-27  8:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25  8:34 Luca Ceresoli
2024-06-27  8:09 ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171947576772.2875250.15838690035445924875.b4-ty@kernel.org \
    --to=lee@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=herve.codina@bootlin.com \
    --cc=linmq006@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=pavel@ucw.cz \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®