From: "Rob Herring (Arm)" <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/1] dt-bindings: soc: fsl: Convert q(b)man-* to yaml format
Date: Fri, 28 Jun 2024 13:34:04 -0600 [thread overview]
Message-ID: <171960324209.86780.5210954798222723537.robh@kernel.org> (raw)
In-Reply-To: <20240626193753.2088926-1-Frank.Li@nxp.com>
On Wed, 26 Jun 2024 15:37:53 -0400, Frank Li wrote:
> Convert qman, bman, qman-portals, bman-portals to yaml format.
>
> Additional Change for fsl,q(b)man-portal:
> - Only keep one example.
> - Add fsl,qman-channel-id property.
> - Use interrupt type macro.
> - Remove top level qman-portals@ff4200000 at example.
>
> Additional change for fsl,q(b)man:
> - Fixed example error.
> - Remove redundent part, only keep fsl,qman node.
> - Change memory-regions to memory-region.
> - fsl,q(b)man-portals is not required property
>
> Additional change for fsl,qman-fqd.yaml:
> - Fixed example error.
> - Only keep one example.
> - Ref to reserve-memory.yaml
> - Merge fsl,bman reserver memory part
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v1 to v2
> - fix typo chang
> - fix typo porta
> - Add | for reg description
> - wrap to 80 for reg descritption
> - memory-region set maxItems: 2
> - fix regex parttern
> - drop See clock-bindings.txt
> - "see reserved-memory.yaml" change to
> "see reserved-memory/reserved-memory.yaml in dtschema project"
>
> - A strange thing in fsl,qman-fqd.yaml, if example compatible string
> change to fsl,qman-fqd, dt_binding_check report below error.
> qman-fqd: False schema does not allow {'compatible': ['fsl,qman-fqd'], 'size': [[4194304]], 'alignment': [[4194304]], 'no-map': True, '$nodename': ['qman-fqd']}
>
> but I replace "fsl,qman-fqd" with "abc", it pass check.
> ---
> .../bindings/soc/fsl/bman-portals.txt | 56 ------
> .../devicetree/bindings/soc/fsl/bman.txt | 137 -------------
> .../bindings/soc/fsl/fsl,bman-portal.yaml | 52 +++++
> .../devicetree/bindings/soc/fsl/fsl,bman.yaml | 83 ++++++++
> .../bindings/soc/fsl/fsl,qman-fqd.yaml | 69 +++++++
> .../bindings/soc/fsl/fsl,qman-portal.yaml | 110 +++++++++++
> .../devicetree/bindings/soc/fsl/fsl,qman.yaml | 93 +++++++++
> .../bindings/soc/fsl/qman-portals.txt | 134 -------------
> .../devicetree/bindings/soc/fsl/qman.txt | 187 ------------------
> 9 files changed, 407 insertions(+), 514 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/soc/fsl/bman-portals.txt
> delete mode 100644 Documentation/devicetree/bindings/soc/fsl/bman.txt
> create mode 100644 Documentation/devicetree/bindings/soc/fsl/fsl,bman-portal.yaml
> create mode 100644 Documentation/devicetree/bindings/soc/fsl/fsl,bman.yaml
> create mode 100644 Documentation/devicetree/bindings/soc/fsl/fsl,qman-fqd.yaml
> create mode 100644 Documentation/devicetree/bindings/soc/fsl/fsl,qman-portal.yaml
> create mode 100644 Documentation/devicetree/bindings/soc/fsl/fsl,qman.yaml
> delete mode 100644 Documentation/devicetree/bindings/soc/fsl/qman-portals.txt
> delete mode 100644 Documentation/devicetree/bindings/soc/fsl/qman.txt
>
Applied, thanks!
prev parent reply other threads:[~2024-06-28 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 19:37 Frank Li
2024-06-28 19:34 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171960324209.86780.5210954798222723537.robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®