From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752722AbcDVAiF (ORCPT ); Thu, 21 Apr 2016 20:38:05 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:46592 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751611AbcDVAiE (ORCPT ); Thu, 21 Apr 2016 20:38:04 -0400 From: "Rafael J. Wysocki" To: Daniel Lezcano , Dave Gerlach Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] cpuidle: Indicate when a device has been unregistered Date: Fri, 22 Apr 2016 02:40:56 +0200 Message-ID: <17196985.m6DKFEgqnD@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160406190047.GA32535@linaro.org> References: <1459883138-21136-1-git-send-email-d-gerlach@ti.com> <20160406190047.GA32535@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, April 06, 2016 12:00:48 PM Daniel Lezcano wrote: > On Tue, Apr 05, 2016 at 02:05:38PM -0500, Dave Gerlach wrote: > > Currently the 'registered' member of the cpuidle_device struct is set > > to 1 during cpuidle_register_device. In this same function there are > > checks to see if the device is already registered to prevent duplicate > > calls to register the device, but this value is never set to 0 even on > > unregister of the device. Because of this, any attempt to call > > cpuidle_register_device after a call to cpuidle_unregister_device will > > fail which shouldn't be the case. > > > > To prevent this, set registered to 0 when the device is unregistered. > > > > Fixes: c878a52d3c7c ("cpuidle: Check if device is already registered") > > Signed-off-by: Dave Gerlach > > --- > > Acked-by: Daniel Lezcano Applied, thanks!