From: Nico Boehr <nrb@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, borntraeger@de.ibm.com, nsg@linux.ibm.com,
seiden@linux.ibm.com, david@redhat.com
Subject: Re: [PATCH v1 1/1] KVM: s390: remove useless include
Date: Wed, 03 Jul 2024 12:24:02 +0200 [thread overview]
Message-ID: <172000224247.95833.192495937410933992@t14-nrb> (raw)
In-Reply-To: <20240702155606.71398-1-imbrenda@linux.ibm.com>
Quoting Claudio Imbrenda (2024-07-02 17:56:06)
> arch/s390/include/asm/kvm_host.h includes linux/kvm_host.h, but
> linux/kvm_host.h includes asm/kvm_host.h .
>
> It turns out that arch/s390/include/asm/kvm_host.h only needs
> linux/kvm_types.h, which it already includes.
>
> Stop including linux/kvm_host.h from arch/s390/include/asm/kvm_host.h .
>
> Due to the #ifdef guards, the code works as it is today, but it's ugly
> and it will get in the way of future patches.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Nico Boehr <nrb@linux.ibm.com>
next prev parent reply other threads:[~2024-07-03 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 15:56 Claudio Imbrenda
2024-07-03 10:24 ` Nico Boehr [this message]
2024-07-03 10:40 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172000224247.95833.192495937410933992@t14-nrb \
--to=nrb@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nsg@linux.ibm.com \
--cc=seiden@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®