From: "Rob Herring (Arm)" <robh@kernel.org>
To: Tao Zhang <quic_taozha@quicinc.com>
Cc: Jie Gan <quic_jiegan@quicinc.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Trilok Soni <quic_tsoni@quicinc.com>,
Mike Leach <mike.leach@linaro.org>,
coresight@lists.linaro.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
James Clark <james.clark@arm.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Song Chai <quic_songchai@quicinc.com>,
Leo Yan <leo.yan@linaro.org>,
Jinlong Mao <quic_jinlmao@quicinc.com>,
devicetree@vger.kernel.org,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH v1 1/3] dt-bindings: arm: qcom,coresight-static-replicator: Add property for source filtering
Date: Fri, 05 Jul 2024 04:38:23 -0600 [thread overview]
Message-ID: <172017590249.2933726.1790899873101654561.robh@kernel.org> (raw)
In-Reply-To: <20240705085152.9063-2-quic_taozha@quicinc.com>
On Fri, 05 Jul 2024 16:51:50 +0800, Tao Zhang wrote:
> Add a new property "filter_src" to label the source corresponding
> to the output connection for a static replicator. By combining
> a funnel and a static replicator in devicetree, a new device that
> supports multi-port input and multi-port output is implemented.
> In order to match the output port with the input port and
> successfully build the trace path, add this new property to
> indicate the data source corresponding to this output port.
>
> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
> ---
> .../arm/arm,coresight-static-replicator.yaml | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml: ^port@[01]$: Missing additionalProperties/unevaluatedProperties constraint
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml: endpoint: Missing additionalProperties/unevaluatedProperties constraint
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240705085152.9063-2-quic_taozha@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-07-05 10:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 8:51 [PATCH v1 0/3] Add source filtering for multi-port output Tao Zhang
2024-07-05 8:51 ` [PATCH v1 1/3] dt-bindings: arm: qcom,coresight-static-replicator: Add property for source filtering Tao Zhang
2024-07-05 9:02 ` Krzysztof Kozlowski
2024-07-09 10:38 ` Suzuki K Poulose
2024-07-05 10:38 ` Rob Herring (Arm) [this message]
2024-07-05 15:23 ` Tao Zhang
2024-07-06 5:22 ` Tao Zhang
2024-07-05 8:51 ` [PATCH v1 2/3] coresight: Add source filtering for multi-port output Tao Zhang
2024-07-09 13:42 ` Suzuki K Poulose
2024-07-11 8:20 ` Tao Zhang
2024-07-05 8:51 ` [PATCH v1 3/3] coresight-tpda: Optimize the function of reading element size Tao Zhang
2024-07-08 15:49 ` Suzuki K Poulose
2024-07-11 8:20 ` Tao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172017590249.2933726.1790899873101654561.robh@kernel.org \
--to=robh@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@arm.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_jiegan@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_songchai@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®