mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>,
	 Viresh Kumar <vireshk@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Mark Brown <broonie@kernel.org>,  Andy Gross <agross@kernel.org>,
	Nishanth Menon <nm@ti.com>,
	 linux-pm@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
	 Robert Marko <robimarko@gmail.com>,
	linux-kernel@vger.kernel.org,
	 Varadarajan Narayanan <quic_varada@quicinc.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	 Ulf Hansson <ulf.hansson@linaro.org>,
	 Viresh Kumar <viresh.kumar@linaro.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	 Marijn Suijten <marijn.suijten@somainline.org>,
	 Rob Herring <robh+dt@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Niklas Cassel <nks@flawful.org>,
	 Liam Girdwood <lgirdwood@gmail.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@somainline.org>
Subject: Re: [PATCH v15 04/10] dt-bindings: soc: qcom: cpr3: Add bindings for CPR3+ driver
Date: Mon, 08 Jul 2024 07:47:13 -0600	[thread overview]
Message-ID: <172044643349.2927781.3846230770478390037.robh@kernel.org> (raw)
In-Reply-To: <20240708-topic-cpr3h-v15-4-5bc8b8936489@linaro.org>


On Mon, 08 Jul 2024 14:22:35 +0200, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> 
> Add the bindings for the Qualcomm CPR3+ hardware.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> [Konrad: Make binding check pass, some other changes]
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  .../devicetree/bindings/soc/qcom/qcom,cpr3.yaml    | 286 +++++++++++++++++++++
>  1 file changed, 286 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.example.dtb: opp-table-cprh: opp-1:qcom,opp-cloop-vadj:0: [0] is too short
	from schema $id: http://devicetree.org/schemas/opp/opp-v2-qcom-level.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.example.dtb: opp-table-cprh: opp-1:qcom,opp-oloop-vadj:0: [0] is too short
	from schema $id: http://devicetree.org/schemas/opp/opp-v2-qcom-level.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.example.dtb: opp-table-cprh: opp-2:qcom,opp-cloop-vadj:0: [0] is too short
	from schema $id: http://devicetree.org/schemas/opp/opp-v2-qcom-level.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.example.dtb: opp-table-cprh: opp-2:qcom,opp-oloop-vadj:0: [0] is too short
	from schema $id: http://devicetree.org/schemas/opp/opp-v2-qcom-level.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.example.dtb: opp-table-cprh: opp-3:qcom,opp-cloop-vadj:0: [0] is too short
	from schema $id: http://devicetree.org/schemas/opp/opp-v2-qcom-level.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.example.dtb: opp-table-cprh: opp-3:qcom,opp-oloop-vadj:0: [0] is too short
	from schema $id: http://devicetree.org/schemas/opp/opp-v2-qcom-level.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240708-topic-cpr3h-v15-4-5bc8b8936489@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-07-08 13:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 12:22 [PATCH v15 00/10] Add support for Core Power Reduction v3, v4 and Hardened Konrad Dybcio
2024-07-08 12:22 ` [PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list Konrad Dybcio
2024-07-09  9:04   ` Krzysztof Kozlowski
2024-07-09  9:49     ` Konrad Dybcio
2024-07-09 14:42       ` Krzysztof Kozlowski
2024-07-15 11:34         ` Ulf Hansson
2024-07-16 11:58           ` Konrad Dybcio
2024-07-16 14:47             ` Ulf Hansson
2024-07-16 15:53               ` Krzysztof Kozlowski
2024-07-08 12:22 ` [PATCH v15 02/10] dt-bindings: opp: v2-qcom-level: Document CPR3 open/closed loop volt adjustment Konrad Dybcio
2024-07-08 12:22 ` [PATCH v15 03/10] dt-bindings: opp: v2-qcom-level: Allow opp-shared Konrad Dybcio
2024-07-09  9:04   ` Krzysztof Kozlowski
2024-07-08 12:22 ` [PATCH v15 04/10] dt-bindings: soc: qcom: cpr3: Add bindings for CPR3+ driver Konrad Dybcio
2024-07-08 13:47   ` Rob Herring (Arm) [this message]
2024-07-08 12:22 ` [PATCH v15 05/10] soc: qcom: cpr: Move common functions to new file Konrad Dybcio
2024-07-08 12:22 ` [PATCH v15 06/10] soc: qcom: cpr-common: Add support for flat fuse adjustment Konrad Dybcio
2024-07-08 12:22 ` [PATCH v15 07/10] soc: qcom: cpr: Use u64 for frequency Konrad Dybcio
2024-07-08 12:22 ` [PATCH v15 08/10] soc: qcom: cpr-common: Add threads support Konrad Dybcio
2024-07-08 12:22 ` [PATCH v15 09/10] soc: qcom: Add a driver for CPR3+ Konrad Dybcio
2024-07-08 14:14   ` Dmitry Baryshkov
2024-08-05  8:43   ` Varadarajan Narayanan
2024-07-08 12:22 ` [PATCH v15 10/10] arm64: dts: qcom: msm8998: Configure CPRh Konrad Dybcio
2024-09-05 11:00 ` [PATCH v15 00/10] Add support for Core Power Reduction v3, v4 and Hardened Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172044643349.2927781.3846230770478390037.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=nks@flawful.org \
    --cc=nm@ti.com \
    --cc=quic_jhugo@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robimarko@gmail.com \
    --cc=sboyd@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®