From: "Rob Herring (Arm)" <robh@kernel.org>
To: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
imx@lists.linux.dev, Catalin Marinas <catalin.marinas@arm.com>,
devicetree@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org, Xiubo Li <Xiubo.Lee@gmail.com>,
Mark Brown <broonie@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Will Deacon <will@kernel.org>, Fabio Estevam <festevam@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-sound@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
Philip-Dylan <philip-dylan.gleonec@savoirfairelinux.com>
Subject: Re: [PATCH v6 5/7] ASoC: dt-bindings: update fsl-asoc-card bindings after imx-spdif merge
Date: Mon, 8 Jul 2024 08:47:25 -0600 [thread overview]
Message-ID: <172045004389.3168553.9456011538931000974.robh@kernel.org> (raw)
In-Reply-To: <20240627083104.123357-6-elinor.montmasson@savoirfairelinux.com>
On Thu, 27 Jun 2024 10:31:02 +0200, Elinor Montmasson wrote:
> The S/PDIF audio card support with compatible "fsl,imx-audio-spdif"
> was merged from imx-spdif into the fsl-asoc-card driver.
> It makes possible to use an S/PDIF with an ASRC.
>
> This merge introduces new DT bindings to use with compatible
> "fsl,imx-audio-spdif" to follow the way fsl-asoc-card works:
> * the "spdif-controller" property from imx-spdif is named "audio-cpu"
> in fsl-asoc-card.
> * fsl-asoc-card uses codecs explicitly declared in DT
> with "audio-codec".
> With an SPDIF, codec drivers spdif_transmitter and
> spdif_receiver should be used.
> Driver imx-spdif used instead the dummy codec and a pair of
> boolean properties, "spdif-in" and "spdif-out".
>
> In an upcoming commit, in-tree DTs will be modified to follow these new
> properties:
> * Property "spdif-controller" will be renamed "audio-cpu".
> * spdif_transmitter and spdif_receiver nodes will be declared
> and linked to the fsl-asoc-card node with the property "audio-codec".
>
> To keep backward compatibility with other DTs, support for
> "spdif-controller", "spdif-in" and "spdif-out" properties is kept.
> However, it is recommended to use the new properties if possible.
> It is better to declare transmitter and/or receiver
> in DT than using the dummy codec.
>
> DTs using compatible "fsl,imx-audio-spdif" are still supported, and
> fsl-asoc-card will behave the same as imx-spdif for these DTs.
>
> Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
> ---
> .../bindings/sound/fsl,imx-audio-spdif.yaml | 66 -------------------
> .../bindings/sound/fsl-asoc-card.yaml | 53 +++++++++++++--
> 2 files changed, 49 insertions(+), 70 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/fsl,imx-audio-spdif.yaml
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2024-07-08 14:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 8:30 [PATCH v6 0/7] ASoC: fsl-asoc-card: add S/PDIF controller support Elinor Montmasson
2024-06-27 8:30 ` [PATCH v6 1/7] ASoC: fsl-asoc-card: add support for dai links with multiple codecs Elinor Montmasson
2024-06-27 8:30 ` [PATCH v6 2/7] ASoC: fsl-asoc-card: add second dai link component for codecs Elinor Montmasson
2024-06-27 8:31 ` [PATCH v6 3/7] ASoC: fsl-asoc-card: add compatibility to use 2 codecs in dai-links Elinor Montmasson
2024-06-27 8:31 ` [PATCH v6 4/7] ASoC: fsl-asoc-card: merge spdif support from imx-spdif.c Elinor Montmasson
2024-06-27 8:31 ` [PATCH v6 5/7] ASoC: dt-bindings: update fsl-asoc-card bindings after imx-spdif merge Elinor Montmasson
2024-07-08 14:47 ` Rob Herring (Arm) [this message]
2024-06-27 8:31 ` [PATCH v6 6/7] arm64: dts: imx8m: update spdif sound card node properties Elinor Montmasson
2024-08-04 14:31 ` Shawn Guo
2024-08-19 11:43 ` Elinor Montmasson
2024-06-27 8:31 ` [PATCH v6 7/7] ARM: dts: imx6: " Elinor Montmasson
2024-07-08 19:14 ` (subset) [PATCH v6 0/7] ASoC: fsl-asoc-card: add S/PDIF controller support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172045004389.3168553.9456011538931000974.robh@kernel.org \
--to=robh@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elinor.montmasson@savoirfairelinux.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=philip-dylan.gleonec@savoirfairelinux.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=tiwai@suse.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®