From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Umang Jain <umang.jain@ideasonboard.com>, linux-media@vger.kernel.org
Cc: Alexander Shiyan <eagle.alexander923@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>,
Umang Jain <umang.jain@ideasonboard.com>
Subject: Re: [PATCH 1/2] media: imx335: Rectify name of mode struct
Date: Wed, 10 Jul 2024 10:45:07 +0100 [thread overview]
Message-ID: <172060470724.392292.7908105003803538787@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <20240710044633.81372-2-umang.jain@ideasonboard.com>
Quoting Umang Jain (2024-07-10 05:46:31)
> In commit 81495a59baeb ("media: imx335: Fix active area height discrepency")
> the height for the mode struct was rectified to '1944'. However, the
> name of mode struct is still reflecting to '1940'. Update it.
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
> drivers/media/i2c/imx335.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index 990d74214cc2..6c1e61b6696b 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -252,7 +252,7 @@ static const int imx335_tpg_val[] = {
> };
>
> /* Sensor mode registers */
> -static const struct cci_reg_sequence mode_2592x1940_regs[] = {
> +static const struct cci_reg_sequence mode_2592x1944_regs[] = {
> { IMX335_REG_MODE_SELECT, IMX335_MODE_STANDBY },
> { IMX335_REG_MASTER_MODE, 0x00 },
> { IMX335_REG_WINMODE, 0x04 },
> @@ -416,8 +416,8 @@ static const struct imx335_mode supported_mode = {
> .vblank_max = 133060,
> .pclk = 396000000,
> .reg_list = {
> - .num_of_regs = ARRAY_SIZE(mode_2592x1940_regs),
> - .regs = mode_2592x1940_regs,
> + .num_of_regs = ARRAY_SIZE(mode_2592x1944_regs),
> + .regs = mode_2592x1944_regs,
> },
> };
>
> --
> 2.45.0
>
next prev parent reply other threads:[~2024-07-10 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 4:46 [PATCH 0/2] media: imx335: Support vertical flip Umang Jain
2024-07-10 4:46 ` [PATCH 1/2] media: imx335: Rectify name of mode struct Umang Jain
2024-07-10 8:21 ` Tommaso Merciai
2024-07-10 9:45 ` Kieran Bingham [this message]
2024-07-10 4:46 ` [PATCH 2/2] media: imx335: Support vertical flip Umang Jain
2024-07-10 8:51 ` Tommaso Merciai
2024-07-10 9:44 ` Kieran Bingham
2024-07-31 7:14 ` [PATCH 0/2] " Umang Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172060470724.392292.7908105003803538787@ping.linuxembedded.co.uk \
--to=kieran.bingham@ideasonboard.com \
--cc=eagle.alexander923@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®