mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Arnd Bergmann <arnd@kernel.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] gpio: virtuser: avoid non-constant format string
Date: Fri, 19 Jul 2024 16:58:18 +0200	[thread overview]
Message-ID: <172140109528.139764.1997443396332853714.b4-ty@linaro.org> (raw)
In-Reply-To: <20240719144422.2082394-1-arnd@kernel.org>

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Fri, 19 Jul 2024 16:44:10 +0200, Arnd Bergmann wrote:
> Using a string variable as an sprintf format is potentially
> dangerous, and gcc can warn about this:
> 
> drivers/gpio/gpio-virtuser.c: In function 'gpio_virtuser_dbgfs_init_line_attrs':
> drivers/gpio/gpio-virtuser.c:808:9: error: format not a string literal and no format arguments [-Werror=format-security]
>   808 |         sprintf(data->consumer, id);
>       |         ^~~~~~~
> 
> [...]

Applied, thanks!

[1/1] gpio: virtuser: avoid non-constant format string
      commit: 3ae08e47742eeebf2190900d31ddac53fdd13a5b

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

      reply	other threads:[~2024-07-19 14:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-19 14:44 Arnd Bergmann
2024-07-19 14:58 ` Bartosz Golaszewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172140109528.139764.1997443396332853714.b4-ty@linaro.org \
    --to=brgl@bgdev.pl \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®