From: Lee Jones <lee@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Jack Chen <zenghuchen@google.com>
Cc: Mark Brown <broonie@kernel.org>,
Vadim Pasternak <vadimp@nvidia.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: (subset) [PATCH v2] leds: lm3601x: Calculate max_brightness and brightness properly
Date: Thu, 25 Jul 2024 08:37:25 +0100 [thread overview]
Message-ID: <172189304588.827855.15843679475980331109.b4-ty@kernel.org> (raw)
In-Reply-To: <20240704191500.766846-1-zenghuchen@google.com>
On Thu, 04 Jul 2024 15:15:00 -0400, Jack Chen wrote:
> The torch_current_max should be checked not exceeding the upper bound.
> If it does, throw a warning message and set to LM3601X_MAX_TORCH_I_UA.
>
> LM3601x torch brigthness register (LM3601X_LED_TORCH_REG) takes 0 as the
> minimum output (2.4 mA). However, 0 of led_brightness means LED_OFF.
> Adding a -1 offset to brightness before writing to brightness
> register, so when users write minimum brightness (1), it sets lm3601x
> output the minimum.
>
> [...]
Applied, thanks!
[1/1] leds: lm3601x: Calculate max_brightness and brightness properly
commit: ef23c7b35efb9cfa0b56fbb7fdf3aa782b1c2b87
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-07-25 7:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 19:15 Jack Chen
2024-07-25 7:37 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172189304588.827855.15843679475980331109.b4-ty@kernel.org \
--to=lee@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
--cc=vadimp@nvidia.com \
--cc=zenghuchen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®