From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B737C282D7 for ; Wed, 30 Jan 2019 10:44:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00A1720857 for ; Wed, 30 Jan 2019 10:44:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730394AbfA3Kn7 (ORCPT ); Wed, 30 Jan 2019 05:43:59 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:37678 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726548AbfA3Kn7 (ORCPT ); Wed, 30 Jan 2019 05:43:59 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id E9EA93847E5B6917DBE8; Wed, 30 Jan 2019 18:43:56 +0800 (CST) Received: from [127.0.0.1] (10.177.31.96) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.408.0; Wed, 30 Jan 2019 18:43:55 +0800 Subject: Re: [PATCH -next] mtd: rawnand: stm32_fmc2: Make some functions static To: Miquel Raynal References: <20190130100908.19532-1-yuehaibing@huawei.com> <20190130113428.37570a55@xps13> CC: , , , , , , , , , , , From: YueHaibing Message-ID: <17220216-4b18-be33-78e2-5cfc517aed27@huawei.com> Date: Wed, 30 Jan 2019 18:43:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20190130113428.37570a55@xps13> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/1/30 18:34, Miquel Raynal wrote: > Hi Yue, > > YueHaibing wrote on Wed, 30 Jan 2019 18:09:08 > +0800: > >> Fixes the following sparse warning: >> drivers/mtd/nand/raw/stm32_fmc2_nand.c:1228:6: warning: symbol 'stm32_fmc2_read_data' was not declared. Should it be static? >> drivers/mtd/nand/raw/stm32_fmc2_nand.c:1275:6: warning: symbol 'stm32_fmc2_write_data' was not declared. Should it be static? >> drivers/mtd/nand/raw/stm32_fmc2_nand.c:1707:32: warning: symbol 'stm32_fmc2_nand_ooblayout_ops' was not declared. Should it be static? >> >> Signed-off-by: YueHaibing >> --- >> drivers/mtd/nand/raw/stm32_fmc2_nand.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c >> index e057282..999ca6a 100644 >> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c >> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c >> @@ -1225,8 +1225,8 @@ static irqreturn_t stm32_fmc2_irq(int irq, void *dev_id) >> return IRQ_HANDLED; >> } >> >> -void stm32_fmc2_read_data(struct nand_chip *chip, void *buf, >> - unsigned int len, bool force_8bit) >> +static void stm32_fmc2_read_data(struct nand_chip *chip, void *buf, >> + unsigned int len, bool force_8bit) >> { >> struct stm32_fmc2_nfc *fmc2 = to_stm32_nfc(chip->controller); >> void __iomem *io_addr_r = fmc2->data_base[fmc2->cs_sel]; >> @@ -1272,8 +1272,8 @@ void stm32_fmc2_read_data(struct nand_chip *chip, void *buf, >> stm32_fmc2_set_buswidth_16(fmc2, true); >> } >> >> -void stm32_fmc2_write_data(struct nand_chip *chip, const void *buf, >> - unsigned int len, bool force_8bit) >> +static void stm32_fmc2_write_data(struct nand_chip *chip, const void *buf, >> + unsigned int len, bool force_8bit) >> { >> struct stm32_fmc2_nfc *fmc2 = to_stm32_nfc(chip->controller); >> void __iomem *io_addr_w = fmc2->data_base[fmc2->cs_sel]; >> @@ -1704,7 +1704,7 @@ static int stm32_fmc2_nand_ooblayout_free(struct mtd_info *mtd, int section, >> return 0; >> } >> >> -const struct mtd_ooblayout_ops stm32_fmc2_nand_ooblayout_ops = { >> +static const struct mtd_ooblayout_ops stm32_fmc2_nand_ooblayout_ops = { >> .ecc = stm32_fmc2_nand_ooblayout_ecc, >> .free = stm32_fmc2_nand_ooblayout_free, >> }; > > This is nand/next material, so if you don't mind I would like to squash > this fix into the original commit inserting the driver. Sure, ok > > > Thanks, > Miquèl > > . >