From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933767AbdCLJMJ (ORCPT ); Sun, 12 Mar 2017 05:12:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49194 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933310AbdCLJL5 (ORCPT ); Sun, 12 Mar 2017 05:11:57 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170312062941.862-1-ebiggers3@gmail.com> References: <20170312062941.862-1-ebiggers3@gmail.com> To: Eric Biggers Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, Al Viro , linux-kernel@vger.kernel.org, Eric Biggers Subject: Re: [PATCH v3] statx: optimize copy of struct statx to userspace MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17225.1489309913.1@warthog.procyon.org.uk> Date: Sun, 12 Mar 2017 09:11:53 +0000 Message-ID: <17226.1489309913@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sun, 12 Mar 2017 09:11:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Biggers wrote: > +static int cp_statx(const struct kstat *stat, struct statx __user *buffer) > ... > + struct statx tmp; This function needs to be "noinline" as tmp is big. > - return statx_set_result(&stat, buffer); > + > + return cp_statx(&stat, buffer); Can you leave it as statx_set_result rather than renaming it to cp_statx? David