mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Yunhong Jiang <yunhong.jiang@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, linux-hyperv@vger.kernel.org,
	 haiyangz@microsoft.com, krzk+dt@kernel.org, x86@kernel.org,
	 wei.liu@kernel.org, dave.hansen@linux.intel.com,
	devicetree@vger.kernel.org,  hpa@zytor.com,
	linux-kernel@vger.kernel.org, bp@alien8.de,  tglx@linutronix.de,
	mingo@redhat.com, rafael@kernel.org, kys@microsoft.com,
	 kirill.shutemov@linux.intel.com, conor+dt@kernel.org,
	lenb@kernel.org,  decui@microsoft.com
Subject: Re: [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox
Date: Tue, 06 Aug 2024 17:38:25 -0600	[thread overview]
Message-ID: <172298750308.229414.6420535043181861002.robh@kernel.org> (raw)
In-Reply-To: <20240806221237.1634126-3-yunhong.jiang@linux.intel.com>


On Tue, 06 Aug 2024 15:12:32 -0700, Yunhong Jiang wrote:
> Add the binding to use the ACPI wakeup mailbox mechanism to bringup APs.
> 
> Signed-off-by: Yunhong Jiang <yunhong.jiang@linux.intel.com>
> ---
>  .../devicetree/bindings/x86/wakeup.yaml       | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/x86/wakeup.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/x86/wakeup.yaml:4:1: [error] syntax error: expected '<document start>', but found '<block mapping start>' (syntax)
./Documentation/devicetree/bindings/x86/wakeup.yaml:41:111: [warning] line too long (153 > 110 characters) (line-length)

dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/x86/wakeup.example.dts'
Documentation/devicetree/bindings/x86/wakeup.yaml:4:1: did not find expected <document start>
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/x86/wakeup.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/x86/wakeup.yaml:4:1: did not find expected <document start>
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/x86/wakeup.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240806221237.1634126-3-yunhong.jiang@linux.intel.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-08-06 23:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-06 22:12 [PATCH 0/7] x86/acpi: Move ACPI MADT wakeup to generic code Yunhong Jiang
2024-08-06 22:12 ` [PATCH 1/7] " Yunhong Jiang
2024-08-06 22:12 ` [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox Yunhong Jiang
2024-08-06 23:38   ` Rob Herring (Arm) [this message]
2024-08-07 17:00     ` Yunhong Jiang
2024-08-07  5:57   ` Krzysztof Kozlowski
2024-08-07 16:56     ` Yunhong Jiang
2024-08-08  7:41       ` Krzysztof Kozlowski
2024-08-09 23:29         ` Yunhong Jiang
2024-08-06 22:12 ` [PATCH 3/7] x86/dt: Support the ACPI multiprocessor wakeup for device tree Yunhong Jiang
2024-08-07 16:50   ` Thomas Gleixner
2024-08-06 22:12 ` [PATCH 4/7] x86/hyperv: Parse the ACPI wakeup mailbox Yunhong Jiang
2024-08-06 22:12 ` [PATCH 5/7] x86/hyperv: Mark ACPI wakeup mailbox page as private Yunhong Jiang
2024-08-07 16:59   ` Thomas Gleixner
2024-08-09 23:17     ` Yunhong Jiang
2024-08-06 22:12 ` [PATCH 6/7] x86/hyperv: Reserve real mode when ACPI wakeup mailbox is available Yunhong Jiang
2024-08-07 17:33   ` Thomas Gleixner
2024-08-24  0:17     ` Yunhong Jiang
2024-08-06 22:12 ` [PATCH 7/7] x86/hyperv: Use the ACPI wakeup mailbox for VTL2 guests when available Yunhong Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172298750308.229414.6420535043181861002.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bp@alien8.de \
    --cc=conor+dt@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=decui@microsoft.com \
    --cc=devicetree@vger.kernel.org \
    --cc=haiyangz@microsoft.com \
    --cc=hpa@zytor.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=krzk+dt@kernel.org \
    --cc=kys@microsoft.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rafael@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wei.liu@kernel.org \
    --cc=x86@kernel.org \
    --cc=yunhong.jiang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®