From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D4DB2F5A; Wed, 7 Aug 2024 05:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723008225; cv=none; b=KK4iM4izaySYtQsUgyxd3cNeOLHXncMdX0qFrltpWqQdGrDOb9KxU1zg7+kXCr6buMnqKzWAuBywn7ZOgOOPDLUJA9c4J0MmLIPW5LIVc/3XT2eQA8Me/6ViXbuD6O7l3ix1yrsNRGyKt2U/vDklilIFDgMUB8fUPCkSbs84CAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723008225; c=relaxed/simple; bh=X7jyXLUcRUzTUYRwdQeb+64IY92ftyBRyeBz4apOoJk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=UfsTiN8xCIvKUvScBnVjlvUeZX2MMTc9A52Tuse2N+uHpOX4fQ6/LdnQBJp825TzH2EgXDJyg5H6cm8IK/cOfql4cSvewxU0AJpgkwiQT6odhLTODVMpaBjbaSfqIzNFU9V+fa4wpfT2Oa0mCZjEhegp551qpuFUf9p/Pe/Pq5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I7R7F53o; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I7R7F53o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2005C32782; Wed, 7 Aug 2024 05:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723008224; bh=X7jyXLUcRUzTUYRwdQeb+64IY92ftyBRyeBz4apOoJk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I7R7F53oW94j5HuM1QgVOsgKY0yVWJDUoromLSMD1QjTdhi7XFkvsRWdQ2uRxcyQ/ bc5bgIZYEg+AVXMc8F8fHcr5RK9y7TdRgnuL4lQ/6xZ9ApCH/7EHsGnoYIUJHdr1WG u7LWUi+qChdvsXEx9L+wkzcNa6MpIaoI2CWPHlFY0Ffowt+Qd0nTcLjytmNfomMm1W pb1swJQxmqCVkzBu1MUb++vWpnedjaK26ihVUgcVwZk1WLwKGCOrNqTpHgug2k0fBh UyXT9VhCc3yzKOL9CVO21jakqYdKDmcrLlZFg7BKZL4uJvgSegztejXcm1uDigg1AY K0/Xnl4oCYM5w== From: Kees Cook To: "Eric W. Biederman" , Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Brian Mak Cc: Kees Cook , Oleg Nesterov , Linus Torvalds Subject: Re: [PATCH v3] binfmt_elf: Dump smaller VMAs first in ELF cores Date: Tue, 6 Aug 2024 22:21:22 -0700 Message-Id: <172300808013.2419749.16446009147309523545.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <036CD6AE-C560-4FC7-9B02-ADD08E380DC9@juniper.net> References: <036CD6AE-C560-4FC7-9B02-ADD08E380DC9@juniper.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Tue, 06 Aug 2024 18:16:02 +0000, Brian Mak wrote: > Large cores may be truncated in some scenarios, such as with daemons > with stop timeouts that are not large enough or lack of disk space. This > impacts debuggability with large core dumps since critical information > necessary to form a usable backtrace, such as stacks and shared library > information, are omitted. > > We attempted to figure out which VMAs are needed to create a useful > backtrace, and it turned out to be a non-trivial problem. Instead, we > try simply sorting the VMAs by size, which has the intended effect. > > [...] While waiting on rr test validation, and since we're at the start of the dev cycle, I figure let's get this into -next ASAP to see if anything else pops out. We can drop/revise if there are problems. (And as always, I will add any Acks/Reviews/etc that show up on the thread.) Applied to for-next/execve, thanks! [1/1] binfmt_elf: Dump smaller VMAs first in ELF cores https://git.kernel.org/kees/c/9c531dfdc1bc Take care, -- Kees Cook