From: Kees Cook <kees@kernel.org>
To: Andy Shevchenko <andy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Justin Stitt <justinstitt@google.com>
Cc: Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] lib/string_helpers: rework overflow-dependent code
Date: Mon, 12 Aug 2024 11:43:20 -0700 [thread overview]
Message-ID: <172348819834.2826487.9112203772355447388.b4-ty@kernel.org> (raw)
In-Reply-To: <20240808-b4-string_helpers_caa133-v1-1-686a455167c4@google.com>
On Thu, 08 Aug 2024 14:43:56 -0700, Justin Stitt wrote:
> When @size is 0, the desired behavior is to allow unlimited bytes to be
> parsed. Currently, this relies on some intentional arithmetic overflow
> where --size gives us SIZE_MAX when size is 0.
>
> Explicitly spell out the desired behavior without relying on intentional
> overflow/underflow.
>
> [...]
Since we can't have allocations larger than INT_MAX, SIZE_MAX is
sufficiently large for this use-case, and the "off by one" introduce
here isn't meaningful. I prefer the improved readability and lack of
wrapping pre-decrement.
Applied to for-next/hardening, thanks!
[1/1] lib/string_helpers: rework overflow-dependent code
https://git.kernel.org/kees/c/5d6b91b74ccd
Take care,
--
Kees Cook
next prev parent reply other threads:[~2024-08-12 18:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 21:43 Justin Stitt
2024-08-08 22:07 ` Andy Shevchenko
2024-08-08 23:11 ` Kees Cook
2024-08-09 11:07 ` Andy Shevchenko
2024-08-09 23:53 ` Justin Stitt
2024-08-10 15:39 ` Andy Shevchenko
2024-08-10 15:41 ` Andy Shevchenko
2024-08-12 18:20 ` Justin Stitt
2024-08-12 18:43 ` Kees Cook [this message]
2024-08-12 20:05 ` Justin Stitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172348819834.2826487.9112203772355447388.b4-ty@kernel.org \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®