From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Maximilian Luz <luzmaximilian@gmail.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/surface: aggregator: Fix warning when controller is destroyed in probe
Date: Tue, 13 Aug 2024 11:21:30 +0300 [thread overview]
Message-ID: <172353729019.2056.10875402139846681143.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20240811124645.246016-1-luzmaximilian@gmail.com>
On Sun, 11 Aug 2024 14:46:44 +0200, Maximilian Luz wrote:
> There is a small window in ssam_serial_hub_probe() where the controller
> is initialized but has not been started yet. Specifically, between
> ssam_controller_init() and ssam_controller_start(). Any failure in this
> window, for example caused by a failure of serdev_device_open(),
> currently results in an incorrect warning being emitted.
>
> In particular, any failure in this window results in the controller
> being destroyed via ssam_controller_destroy(). This function checks the
> state of the controller and, in an attempt to validate that the
> controller has been cleanly shut down before we try and deallocate any
> resources, emits a warning if that state is not SSAM_CONTROLLER_STOPPED.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/surface: aggregator: Fix warning when controller is destroyed in probe
commit: bc923d594db21bee0ead128eb4bb78f7e77467a4
--
i.
prev parent reply other threads:[~2024-08-13 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-11 12:46 Maximilian Luz
2024-08-13 8:21 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172353729019.2056.10875402139846681143.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®